warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Disconnect if user tries to give themselves too much skill (#1922)

Browse source
This commit is contained in:
Kamron Batman 2024-08-10 12:49:39 -07:00 • committed by GitHub
parent a86601ffea
commit 03a6edad45
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Projects/UOContent/Misc/CharacterCreation.cs
View file

@ -444,21 +444,32 @@ public static class CharacterCreation
for (var i = 0; i < skills.Length; ++i)
{
var (name, value) = skills[i];
var notValid = value is < 0 or > 50 || !_allowedStartingSkills.Contains(name) ||
!Core.AOS && name is SkillName.Necromancy or SkillName.Chivalry or SkillName.Focus ||
!Core.SE && name is SkillName.Ninjitsu or SkillName.Bushido ||
Core.SA && (raceFlag == Race.AllowGargoylesOnly && name == SkillName.Archery ||
raceFlag != Race.AllowGargoylesOnly && name == SkillName.Throwing) ||
!Core.SA && name is SkillName.Throwing or SkillName.Imbuing;
if (notValid)
if (value is < 0 or > 50 || !_allowedStartingSkills.Contains(name))
{
skills[i] = default;
continue;
return false;
}
/**
* Note: Change to Alchemy @ 0 skill if something invalid is chosen.
* To avoid this, modify the client to only show the skills allowed by your shard.
*/
switch (name)
{
case SkillName.Necromancy or SkillName.Chivalry or SkillName.Focus when !Core.AOS:
case SkillName.Ninjitsu or SkillName.Bushido when !Core.SE:
case SkillName.Throwing or SkillName.Imbuing when !Core.SA:
case SkillName.Archery when raceFlag == Race.AllowGargoylesOnly:
case SkillName.Throwing when raceFlag != Race.AllowGargoylesOnly:
{
skills[i] = default;
break;
}
}
total += value;
// Do not allow a skill to be listed twice
for (var j = i + 1; j < skills.Length; ++j)
{
var (nameCheck, valueCheck) = skills[j];