warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): Adds SkipLocalsInitAttribute support, optimizes broadcasted packets (#363)

Browse source 
- [X] Adds support for `SkipLocalsInitAttribute`. SkipLocalsInitAttribute skips initializing stack variables including `stackalloc`. I don't think it is wired/working yet but should be implemented soon.
- [X] Optimizes broadcasted packets by checking if the first byte (packet ID) is non-zero. If it is already set, it reuses the buffer.
- [X] Removes unnecessary refs to Spans. I don't think the Span struct itself is mutable, so a ref is not helpful.
This commit is contained in:
Kamron Batman 2020-12-26 12:46:06 -08:00 • committed by GitHub
parent 9c9591b098
commit 03d0a4664e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 478 additions and 285 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Projects/Server/Network/Packets/OutgoingEffectPackets.cs
View file

@ -33,12 +33,12 @@ namespace Server.Network
}
Span<byte> buffer = stackalloc byte[SoundPacketLength];
CreateSoundEffect(ref buffer, soundID, target);
CreateSoundEffect(buffer, soundID, target);
ns.Send(buffer);
}
public static void CreateSoundEffect(ref Span<byte> buffer, int soundID, IPoint3D target)
public static void CreateSoundEffect(Span<byte> buffer, int soundID, IPoint3D target)
{
var writer = new SpanWriter(buffer);
writer.Write((byte)0x54); // Packet ID
@ -51,7 +51,7 @@ namespace Server.Network
}
public static void CreateParticleEffect(
ref Span<byte> buffer,
Span<byte> buffer,
EffectType type, Serial from, Serial to, int itemID, IPoint3D fromPoint, IPoint3D toPoint,
int speed, int duration, bool fixedDirection, bool explode, int hue, int renderMode, int effect,
int explodeEffect, int explodeSound, Serial serial, int layer, int unknown
@ -86,10 +86,10 @@ namespace Server.Network
}
public static void CreateTargetParticleEffect(
ref Span<byte> buffer,
Span<byte> buffer,
IEntity e, int itemID, int speed, int duration, int hue, int renderMode, int effect, int layer, int unknown
) => CreateParticleEffect(
ref buffer,
buffer,
EffectType.FixedFrom,
e.Serial,
Serial.Zero,
@ -111,10 +111,10 @@ namespace Server.Network
);
public static void CreateLocationParticleEffect(
ref Span<byte> buffer,
Span<byte> buffer,
IEntity e, int itemID, int speed, int duration, int hue, int renderMode, int effect, int unknown
) => CreateParticleEffect(
ref buffer,
buffer,
EffectType.FixedXYZ,
e.Serial,
Serial.Zero,
@ -136,12 +136,12 @@ namespace Server.Network
);
public static void CreateMovingParticleEffect(
ref Span<byte> buffer,
Span<byte> buffer,
IEntity from, IEntity to, int itemID, int speed, int duration, bool fixedDirection,
bool explodes, int hue, int renderMode, int effect, int explodeEffect, int explodeSound, EffectLayer layer,
int unknown
) => CreateParticleEffect(
ref buffer,
buffer,
EffectType.Moving,
from.Serial,
to.Serial,
@ -163,7 +163,7 @@ namespace Server.Network
);
public static void CreateHuedEffect(
ref Span<byte> buffer,
Span<byte> buffer,
EffectType type, Serial from, Serial to, int itemID, Point3D fromPoint, Point3D toPoint,
int speed, int duration, bool fixedDirection, bool explode, int hue, int renderMode
)
@ -191,10 +191,10 @@ namespace Server.Network
}
public static void CreateTargetHuedEffect(
ref Span<byte> buffer,
Span<byte> buffer,
IEntity e, int itemID, int speed, int duration, int hue, int renderMode
) => CreateHuedEffect(
ref buffer,
buffer,
EffectType.FixedFrom,
e.Serial,
Serial.Zero,
@ -210,10 +210,10 @@ namespace Server.Network
);
public static void CreateLocationHuedEffect(
ref Span<byte> buffer,
Span<byte> buffer,
Point3D p, int itemID, int speed, int duration, int hue, int renderMode
) => CreateHuedEffect(
ref buffer,
buffer,
EffectType.FixedXYZ,
Serial.Zero,
Serial.Zero,
@ -229,11 +229,11 @@ namespace Server.Network
);
public static void CreateMovingHuedEffect(
ref Span<byte> buffer,
Span<byte> buffer,
IEntity from, IEntity to, int itemID, int speed, int duration, bool fixedDirection,
bool explodes, int hue, int renderMode
) => CreateHuedEffect(
ref buffer,
buffer,
EffectType.Moving,
from.Serial,
to.Serial,
@ -249,11 +249,11 @@ namespace Server.Network
);
public static void CreateMovingHuedEffect(
ref Span<byte> buffer,
Span<byte> buffer,
int itemID, Point3D fromLocation, Point3D toLocation, int speed, int duration,
bool fixedDirection, bool explodes, int hue, int renderMode
) => CreateHuedEffect(
ref buffer,
buffer,
EffectType.Moving,
Serial.Zero,
Serial.Zero,
@ -269,11 +269,11 @@ namespace Server.Network
);
public static void CreateMovingHuedEffect(
ref Span<byte> buffer,
Span<byte> buffer,
Serial from, Serial to, int itemID, Point3D fromLocation, Point3D toLocation, int speed, int duration,
bool fixedDirection, bool explodes, int hue, int renderMode
) => CreateHuedEffect(
ref buffer,
buffer,
EffectType.Moving,
from,
to,
@ -288,8 +288,8 @@ namespace Server.Network
renderMode
);
public static void CreateBoltEffect(ref Span<byte> buffer, IEntity target, int hue) => CreateHuedEffect(
ref buffer,
public static void CreateBoltEffect(Span<byte> buffer, IEntity target, int hue) => CreateHuedEffect(
buffer,
EffectType.Lightning,
target.Serial,
Serial.Zero,