warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): Adds SkipLocalsInitAttribute support, optimizes broadcasted packets (#363)

Browse source 
- [X] Adds support for `SkipLocalsInitAttribute`. SkipLocalsInitAttribute skips initializing stack variables including `stackalloc`. I don't think it is wired/working yet but should be implemented soon.
- [X] Optimizes broadcasted packets by checking if the first byte (packet ID) is non-zero. If it is already set, it reuses the buffer.
- [X] Removes unnecessary refs to Spans. I don't think the Span struct itself is mutable, so a ref is not helpful.
This commit is contained in:
Kamron Batman 2020-12-26 12:46:06 -08:00 • committed by GitHub
parent 9c9591b098
commit 03d0a4664e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 478 additions and 285 deletions
Download patch file Download diff file Expand all files Collapse all files

52
Projects/UOContent/Misc/Guild.cs
View file

@ -331,20 +331,7 @@ namespace Server.Guilds
public void AllianceChat(Mobile from, int hue, string text)
{
Span<byte> buffer = stackalloc byte[OutgoingMessagePackets.GetMaxMessageLength(text)];
var length = OutgoingMessagePackets.CreateMessage(
ref buffer,
from.Serial,
from.Body,
MessageType.Alliance,
hue,
3,
false,
from.Language,
from.Name,
text
);
buffer = buffer.Slice(0, length); // Adjust to the actual size
buffer.InitializePacket();
for (var i = 0; i < m_Members.Count; i++)
{
@ -352,6 +339,24 @@ namespace Server.Guilds
for (var j = 0; j < g.Members.Count; j++)
{
if (buffer[0] == 0)
{
var length = OutgoingMessagePackets.CreateMessage(
buffer,
from.Serial,
from.Body,
MessageType.Alliance,
hue,
3,
false,
from.Language,
from.Name,
text
);
buffer = buffer.Slice(0, length); // Adjust to the actual size
}
g.Members[j].NetState?.Send(buffer);
}
}
@ -1266,7 +1271,7 @@ namespace Server.Guilds
}
else
{
m_AllianceLeader = reader.ReadEntity<Guild>();;
m_AllianceLeader = reader.ReadEntity<Guild>();
}
goto case 4;
@ -1516,15 +1521,20 @@ namespace Server.Guilds
public void GuildChat(Mobile from, int hue, string text)
{
Span<byte> buffer = stackalloc byte[OutgoingMessagePackets.GetMaxMessageLength(text)];
var length = OutgoingMessagePackets.CreateMessage(
ref buffer,
from.Serial, from.Body, MessageType.Guild, hue, 3, false, from.Language, from.Name, text
);
buffer = buffer.Slice(0, length); // Adjust to the actual size
buffer.InitializePacket();
for (var i = 0; i < Members.Count; i++)
{
if (buffer[0] == 0)
{
var length = OutgoingMessagePackets.CreateMessage(
buffer, from.Serial, from.Body, MessageType.Guild, hue, 3, false, from.Language,
from.Name, text
);
buffer = buffer.Slice(0, length); // Adjust to the actual size
}
Members[i].NetState?.Send(buffer);
}
}