fix: Fixes sending packets and sidesteps a major issue with stackalloc and PGO in .NET 8 (#1607)

### Summary
- Works around a sneaky edge case bug in the JIT with stackalloc where sometimes the buffer is not zero'd.
- Fixes SendDisplayBoatHS
- Fixes sending health bars in the `SendEverything()` logic.
- Fixes a bug in sizing for some string helper functions.

### Developer Note
We are enabled `SkipLocalsInit` - do not rely on `stackalloc` to be zero'd. To zero the buffer, use `span.Clear();`

Closes #1606
This commit is contained in:
Kamron Batman 2023-11-21 12:18:20 -08:00 • committed by GitHub
parent 79ba1ea917
commit 03f850fe03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 67 additions and 76 deletions

View file

@ -1001,6 +1001,8 @@ public static class Utility
var length = source.Length;
Span<bool> list = stackalloc bool[length];
list.Clear();
var sampleList = new T[count];
var i = 0;
@ -1025,6 +1027,8 @@ public static class Utility
var length = source.Count;
Span<bool> list = stackalloc bool[length];
list.Clear();
var sampleList = new List<T>(count);
var i = 0;
@ -1049,6 +1053,7 @@ public static class Utility
var length = source.Length;
Span<bool> list = stackalloc bool[length];
list.Clear();
var i = 0;
do