fix(core): Cleans up OPL code (#396)

- [X] Cleans up OPL code to simplify the calls
This commit is contained in:
Kamron Batman 2021-01-09 11:56:05 -08:00 • committed by GitHub
parent 5882b1ab3f
commit 0b9fb9c071
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 70 deletions

View file

@ -17,7 +17,7 @@ namespace Server.Items
public override int LabelNumber => 503057; // Impassable!
public override void SendWorldPacketTo(NetState ns, ReadOnlySpan<byte> world)
public override void SendWorldPacketTo(NetState ns, ReadOnlySpan<byte> world = default)
{
var mob = ns.Mobile;
if (AccessLevel.GameMaster >= mob?.AccessLevel)
@ -29,18 +29,6 @@ namespace Server.Items
SendGMItem(ns);
}
protected override void SendWorldPacketTo(NetState ns)
{
var mob = ns.Mobile;
if (AccessLevel.GameMaster >= mob?.AccessLevel)
{
base.SendWorldPacketTo(ns);
return;
}
SendGMItem(ns);
}
private void SendGMItem(NetState ns)
{
// GM Packet

View file

@ -815,16 +815,6 @@ namespace Server.Items
ns.Send(new CorpseEquip(ns.Mobile, this));
}
public override void SendInfoTo(NetState ns, bool sendOplPacket)
{
base.SendInfoTo(ns, sendOplPacket);
if (((Body)Amount).IsHuman && ItemID == 0x2006)
{
SendCorpseContent(ns);
}
}
public override void SendInfoTo(NetState ns, ReadOnlySpan<byte> world, Span<byte> opl)
{
base.SendInfoTo(ns, world, opl);

View file

@ -23,7 +23,7 @@ namespace Server.Items
TileData.ItemTable[0x21A2].Height = 20;
}
public override void SendWorldPacketTo(NetState ns, ReadOnlySpan<byte> world)
public override void SendWorldPacketTo(NetState ns, ReadOnlySpan<byte> world = default)
{
var mob = ns.Mobile;
if (AccessLevel.GameMaster >= mob?.AccessLevel)
@ -35,18 +35,6 @@ namespace Server.Items
SendGMItem(ns);
}
protected override void SendWorldPacketTo(NetState ns)
{
var mob = ns.Mobile;
if (AccessLevel.GameMaster >= mob?.AccessLevel)
{
base.SendWorldPacketTo(ns);
return;
}
SendGMItem(ns);
}
private void SendGMItem(NetState ns)
{
// GM Packet

View file

@ -880,19 +880,11 @@ namespace Server.Multis
DesignState.SendDetailedInfoTo(ns);
}
public override void SendInfoTo(NetState ns, bool sendOplPacket)
{
base.SendInfoTo(ns, sendOplPacket);
var stateToSend = DesignContext.Find(ns.Mobile)?.Foundation == this ? DesignState : CurrentState;
stateToSend.SendGeneralInfoTo(ns);
}
public override void SendInfoTo(NetState ns, ReadOnlySpan<byte> world, Span<byte> opl)
public override void SendInfoTo(NetState ns, ReadOnlySpan<byte> world = default, Span<byte> opl = default)
{
base.SendInfoTo(ns, world, opl);
var stateToSend = DesignContext.Find(ns.Mobile)?.Foundation == this ? DesignState : CurrentState;
var stateToSend = DesignContext.Find(ns?.Mobile)?.Foundation == this ? DesignState : CurrentState;
stateToSend.SendGeneralInfoTo(ns);
}