From 16d7961dc9bcb777f42f0ca9be0d208a0c5603b8 Mon Sep 17 00:00:00 2001 From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com> Date: Mon, 12 Aug 2024 23:13:53 -0700 Subject: [PATCH] fix: Fixes profession indexing (#1929) --- Projects/UOContent/Misc/ProfessionInfo.cs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Projects/UOContent/Misc/ProfessionInfo.cs b/Projects/UOContent/Misc/ProfessionInfo.cs index 4d6766de2..105927e20 100644 --- a/Projects/UOContent/Misc/ProfessionInfo.cs +++ b/Projects/UOContent/Misc/ProfessionInfo.cs @@ -10,8 +10,7 @@ public class ProfessionInfo private static readonly ProfessionInfo[] _professions; [MethodImpl(MethodImplOptions.AggressiveInlining)] - public static bool VerifyProfession(int profIndex) => - profIndex >= 0 && profIndex < _professions.Length; + public static bool VerifyProfession(int profIndex) => profIndex > 0 && profIndex < _professions.Length; public static bool GetProfession(int profIndex, out ProfessionInfo profession) { @@ -21,7 +20,7 @@ public class ProfessionInfo return false; } - return (profession = _professions[profIndex - 1]) != null; + return (profession = _professions[profIndex]) != null; } private static bool TryGetSkillName(string name, out SkillName skillName) @@ -184,11 +183,15 @@ public class ProfessionInfo } } - _professions = new ProfessionInfo[maxProf]; + _professions = new ProfessionInfo[maxProf + 1]; + _professions[0] = new ProfessionInfo + { + Name = "Advanced Skills" + }; foreach (var p in profs) { - _professions[p.ID - 1] = p; + _professions[p.ID] = p; } profs.Clear();