Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Scripts/Engines/CannedEvil/ChampionSkullBrazier.cs

@@ -65,22 +65,16 @@ namespace Server.Engines.CannedEvil
         Skull = null;
 
       if (from.Map != Map || !from.InRange(GetWorldLocation(), 3))
-      {
         from.SendLocalizedMessage(500446); // That is too far away.
-      }
       else if (!Harrower.CanSpawn)
-      {
         from.SendMessage("The harrower has already been spawned.");
-      }
       else if (m_Skull == null)
       {
         from.SendLocalizedMessage(1049485); // What would you like to sacrifice?
         from.Target = new SacrificeTarget(this);
       }
       else
-      {
-        SendLocalizedMessageTo(from, 1049487, ""); // I already have my champions awakening skull!
-      }
+        SendLocalizedMessageTo(from, 1049487); // I already have my champions awakening skull!
     }
 
     public void EndSacrifice(Mobile from, ChampionSkull skull)
@@ -92,25 +86,15 @@ namespace Server.Engines.CannedEvil
         Skull = null;
 
       if (from.Map != Map || !from.InRange(GetWorldLocation(), 3))
-      {
         from.SendLocalizedMessage(500446); // That is too far away.
-      }
       else if (!Harrower.CanSpawn)
-      {
         from.SendMessage("The harrower has already been spawned.");
-      }
       else if (skull == null)
-      {
-        SendLocalizedMessageTo(from, 1049488, ""); // That is not my champions awakening skull!
-      }
+        SendLocalizedMessageTo(from, 1049488); // That is not my champions awakening skull!
       else if (m_Skull != null)
-      {
-        SendLocalizedMessageTo(from, 1049487, ""); // I already have my champions awakening skull!
-      }
+        SendLocalizedMessageTo(from, 1049487); // I already have my champions awakening skull!
       else if (!skull.IsChildOf(from.Backpack))
-      {
         from.SendLocalizedMessage(1049486); // You can only sacrifice items that are in your backpack!
-      }
       else
       {
         if (skull.Type == Type)
@@ -121,9 +105,7 @@ namespace Server.Engines.CannedEvil
           Skull = skull;
         }
         else
-        {
-          SendLocalizedMessageTo(from, 1049488, ""); // That is not my champions awakening skull!
-        }
+          SendLocalizedMessageTo(from, 1049488); // That is not my champions awakening skull!
       }
     }
 

Projects/Scripts/Engines/CannedEvil/ChampionSpawn.cs

@@ -950,24 +950,24 @@ namespace Server.Engines.CannedEvil
 
       Dictionary<Mobile, int> validEntries = new Dictionary<Mobile, int>();
 
-      foreach (KeyValuePair<Mobile, int> kvp in m_DamageEntries)
-        if (IsEligible(kvp.Key, artifact))
+      foreach (var (key, value) in m_DamageEntries)
+        if (IsEligible(key, artifact))
         {
-          validEntries.Add(kvp.Key, kvp.Value);
-          totalDamage += kvp.Value;
+          validEntries.Add(key, value);
+          totalDamage += value;
         }
 
       int randomDamage = Utility.RandomMinMax(1, totalDamage);
 
       totalDamage = 0;
 
-      foreach (KeyValuePair<Mobile, int> kvp in validEntries)
+      foreach (var (key, value) in validEntries)
       {
-        totalDamage += kvp.Value;
+        totalDamage += value;
 
         if (totalDamage >= randomDamage)
         {
-          GiveArtifact(kvp.Key, artifact);
+          GiveArtifact(key, artifact);
           return;
         }
       }
@@ -1001,10 +1001,10 @@ namespace Server.Engines.CannedEvil
 
       writer.Write(m_SPawnSzMod);
       writer.Write(m_DamageEntries.Count);
-      foreach (KeyValuePair<Mobile, int> kvp in m_DamageEntries)
+      foreach (var (key, value) in m_DamageEntries)
       {
-        writer.Write(kvp.Key);
-        writer.Write(kvp.Value);
+        writer.Write(key);
+        writer.Write(value);
       }
 
       writer.Write(ConfinedRoaming);