Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Scripts/Engines/MLQuests/Gumps/RaceChangeGump.cs

@@ -1,5 +1,7 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
+using Server.Buffers;
 using Server.Gumps;
 using Server.Items;
 using Server.Mobiles;
@@ -87,7 +89,7 @@ namespace Server.Engines.MLQuests.Gumps
       CloseCurrent(ns);
 
       m_Pending[ns] = new RaceChangeState(owner, ns, targetRace);
-      ns.Send(new RaceChanger(from.Female, targetRace));
+      SendRaceChanger(ns, from.Female, targetRace);
     }
 
     private static void CloseCurrent(NetState ns)
@@ -98,7 +100,7 @@ namespace Server.Engines.MLQuests.Gumps
         m_Pending.Remove(ns);
       }
 
-      ns.Send(CloseRaceChanger.Instance);
+      SendCloseRaceChanger(ns);
     }
 
     private static void Timeout(NetState ns)
@@ -106,30 +108,21 @@ namespace Server.Engines.MLQuests.Gumps
       if (IsPending(ns))
       {
         m_Pending.Remove(ns);
-        ns.Send(CloseRaceChanger.Instance);
+        SendCloseRaceChanger(ns);
       }
     }
 
     public static bool IsWearingEquipment(Mobile from)
     {
-      foreach (Item item in from.Items)
-        switch (item.Layer)
+      return from.Items.Select(item => item.Layer switch
         {
-          case Layer.Hair:
-          case Layer.FacialHair:
-          case Layer.Backpack:
-          case Layer.Mount:
-          case Layer.Bank:
-          {
-            continue; // ignore
-          }
-          default:
-          {
-            return true;
-          }
-        }
-
-      return false;
+          Layer.Hair => false,
+          Layer.FacialHair => false,
+          Layer.Backpack => false,
+          Layer.Mount => false,
+          Layer.Bank => false,
+          _ => true
+        }).FirstOrDefault();
     }
 
     private static bool CanChange(PlayerMobile from, Race targetRace)
@@ -238,38 +231,34 @@ namespace Server.Engines.MLQuests.Gumps
         m_Timeout = Timer.DelayCall(m_TimeoutDelay, Timeout, ns);
       }
     }
-  }
 
-  public sealed class RaceChanger : Packet
-  {
-    public RaceChanger(bool female, Race targetRace)
-      : base(0xBF)
+    public static void SendRaceChanger(NetState ns, bool female, Race targetRace)
     {
-      EnsureCapacity(7);
+      if (ns == null)
+        return;
 
-      m_Stream.Write((short)0x2A);
-      m_Stream.Write((byte)(female ? 1 : 0));
-      m_Stream.Write((byte)(targetRace.RaceID + 1));
+      SpanWriter writer = new SpanWriter(stackalloc byte[7]);
+      writer.Write((byte)0xBF); // Packet ID
+      writer.Write((ushort)0x07); // Dynamic Length
+
+      writer.Write((short)0x2A);
+      writer.Write(female);
+      writer.Write((byte)(targetRace.RaceID + 1));
+
+      ns.Send(writer.Span);
+    }
+
+    private static void SendCloseRaceChanger(NetState ns)
+    {
+      ns?.Send(stackalloc byte[]
+      {
+        0xBF, // Packet ID
+        0x07, // Dynamic Length
+        0x00,
+        0xFF
+      });
     }
   }
-
-  public sealed class CloseRaceChanger : Packet
-  {
-    public static readonly Packet Instance = SetStatic(new CloseRaceChanger());
-
-    private CloseRaceChanger()
-      : base(0xBF)
-    {
-      EnsureCapacity(7);
-
-      m_Stream.Write((short)0x2A);
-      m_Stream.Write((byte)0);
-      m_Stream.Write((byte)0xFF);
-    }
-  }
-
-  #region For testing
-
   public class RaceChangeDeed : Item, IRaceChanger
   {
     [Constructible]
@@ -330,6 +319,4 @@ namespace Server.Engines.MLQuests.Gumps
       int version = reader.ReadInt();
     }
   }
-
-  #endregion
 }