Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Scripts/Items/Traps/GasTrap.cs

@@ -35,7 +35,7 @@ namespace Server.Items
     [CommandProperty(AccessLevel.GameMaster)]
     public GasTrapType Type
     {
-      get
+      get => ItemID switch
       {
         return ItemID switch
         {
@@ -69,7 +69,7 @@ namespace Server.Items
       if (Poison == null || !from.Player || !from.Alive || from.AccessLevel > AccessLevel.Player)
         return;
 
-      Effects.SendLocationEffect(Location, Map, GetBaseID(Type) - 2, 16, 3, GetEffectHue(), 0);
+      Effects.SendLocationEffect(Location, Map, GetBaseID(Type) - 2, 16, 3, GetEffectHue());
       Effects.PlaySound(Location, Map, 0x231);
 
       from.ApplyPoison(from, Poison);

Projects/Scripts/Items/Traps/GiantSpikeTrap.cs

@@ -24,7 +24,7 @@ namespace Server.Items
       if (from.AccessLevel > AccessLevel.Player)
         return;
 
-      Effects.SendLocationEffect(Location, Map, 0x1D99, 48, 2, GetEffectHue(), 0);
+      Effects.SendLocationEffect(Location, Map, 0x1D99, 48, 2, GetEffectHue());
 
       if (from.Alive && CheckRange(from.Location, 0))
         SpellHelper.Damage(TimeSpan.FromTicks(1), from, from, Utility.Dice(10, 7, 0));

Projects/Scripts/Items/Traps/SawTrap.cs

@@ -26,7 +26,7 @@ namespace Server.Items
     [CommandProperty(AccessLevel.GameMaster)]
     public SawTrapType Type
     {
-      get
+      get => ItemID switch
       {
         return ItemID switch
         {
@@ -62,7 +62,7 @@ namespace Server.Items
       if (!from.Alive || from.AccessLevel > AccessLevel.Player)
         return;
 
-      Effects.SendLocationEffect(Location, Map, GetBaseID(Type) + 1, 6, 3, GetEffectHue(), 0);
+      Effects.SendLocationEffect(Location, Map, GetBaseID(Type) + 1, 6, 3, GetEffectHue());
       Effects.PlaySound(Location, Map, 0x21C);
 
       SpellHelper.Damage(TimeSpan.FromTicks(1), from, from, Utility.RandomMinMax(5, 15));

Projects/Scripts/Items/Traps/SpikeTrap.cs

@@ -26,7 +26,7 @@ namespace Server.Items
     [CommandProperty(AccessLevel.GameMaster)]
     public SpikeTrapType Type
     {
-      get
+      get => ItemID switch
       {
         return ItemID switch
         {
@@ -56,13 +56,7 @@ namespace Server.Items
     public bool Extended
     {
       get => ItemID == GetExtendedID(Type);
-      set
-      {
-        if (value)
-          ItemID = GetExtendedID(Type);
-        else
-          ItemID = GetBaseID(Type);
-      }
+      set => ItemID = value ? GetExtendedID(Type) : GetBaseID(Type);
     }
 
     public override bool PassivelyTriggered => false;
@@ -101,7 +95,7 @@ namespace Server.Items
       if (!from.Alive || from.AccessLevel > AccessLevel.Player)
         return;
 
-      Effects.SendLocationEffect(Location, Map, GetBaseID(Type) + 1, 18, 3, GetEffectHue(), 0);
+      Effects.SendLocationEffect(Location, Map, GetBaseID(Type) + 1, 18, 3, GetEffectHue());
       Effects.PlaySound(Location, Map, 0x22C);
 
       foreach (Mobile mob in GetMobilesInRange(0))
@@ -122,7 +116,7 @@ namespace Server.Items
     public virtual void OnSpikeRetracted()
     {
       Extended = false;
-      Effects.SendLocationEffect(Location, Map, GetExtendedID(Type) - 1, 6, 3, GetEffectHue(), 0);
+      Effects.SendLocationEffect(Location, Map, GetExtendedID(Type) - 1, 6, 3, GetEffectHue());
     }
 
     public override void Serialize(GenericWriter writer)

Projects/Scripts/Items/Traps/StoneFaceTrap.cs

@@ -40,22 +40,24 @@ namespace Server.Items
       }
       set
       {
-        bool breathing = Breathing;
-
-        ItemID = breathing ? GetFireID(value) : GetBaseID(value);
-      }
+        0x10F5 => StoneFaceTrapType.NorthWestWall,
+        0x10F6 => StoneFaceTrapType.NorthWestWall,
+        0x10F7 => StoneFaceTrapType.NorthWestWall,
+        0x10FC => StoneFaceTrapType.NorthWall,
+        0x10FD => StoneFaceTrapType.NorthWall,
+        0x10FE => StoneFaceTrapType.NorthWall,
+        0x110F => StoneFaceTrapType.WestWall,
+        0x1110 => StoneFaceTrapType.WestWall,
+        0x1111 => StoneFaceTrapType.WestWall,
+        _ => StoneFaceTrapType.NorthWestWall
+      };
+      set => ItemID = Breathing ? GetFireID(value) : GetBaseID(value);
     }
 
     public bool Breathing
     {
       get => ItemID == GetFireID(Type);
-      set
-      {
-        if (value)
-          ItemID = GetFireID(Type);
-        else
-          ItemID = GetBaseID(Type);
-      }
+      set => ItemID = value ? GetFireID(Type) : GetBaseID(Type);
     }
 
     public override bool PassivelyTriggered => true;
@@ -157,4 +159,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}