Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Scripts/Mobiles/Townfolk/Banker.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using Server.Accounting;
 using Server.ContextMenus;
 using Server.Items;
 using Server.Network;
@@ -284,22 +283,16 @@ namespace Server.Mobiles
                   break;
 
                 if (!Core.ML && amount > 5000 || Core.ML && amount > 60000)
-                {
                   Say(500381); // Thou canst not withdraw so much at one time!
-                }
                 else if (pack?.Deleted != false || !(pack.TotalWeight < pack.MaxWeight) ||
                          !(pack.TotalItems < pack.MaxItems))
-                {
                   Say(1048147); // Your backpack can't hold anything else.
-                }
                 else if (amount > 0)
                 {
                   BankBox box = e.Mobile.FindBankNoCreate();
 
                   if (box == null || !Withdraw(e.Mobile, amount))
-                  {
                     Say(500384); // Ah, art thou trying to fool me? Thou hast not so much gold!
-                  }
                   else
                   {
                     pack.DropItem(new Gold(amount));
@@ -365,13 +358,9 @@ namespace Server.Mobiles
                   break;
 
                 if (amount < 5000)
-                {
                   Say(1010006); // We cannot create checks for such a paltry amount of gold!
-                }
                 else if (amount > 1000000)
-                {
                   Say(1010007); // Our policies prevent us from creating checks worth that much!
-                }
                 else
                 {
                   BankCheck check = new BankCheck(amount);

Projects/Scripts/Mobiles/Townfolk/BrideGroom.cs

@@ -50,10 +50,7 @@ namespace Server.Mobiles
       else
         AddItem(new Boots(lowHue));
 
-      if (Utility.RandomBool())
-        HairItemID = 0x203B;
-      else
-        HairItemID = 0x203C;
+      HairItemID = Utility.RandomBool() ? 0x203B : 0x203C;
 
       HairHue = Race.RandomHairHue();
 
@@ -74,4 +71,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/EscortableMage.cs

@@ -68,4 +68,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/Merchant.cs

@@ -77,4 +77,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/Messenger.cs

@@ -66,4 +66,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/Noble.cs

@@ -78,4 +78,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/Peasant.cs

@@ -71,4 +71,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/SeekerOfAdventure.cs

@@ -26,12 +26,7 @@ namespace Server.Mobiles
 
     public override bool ClickTitle => false; // Do not display 'the seeker of adventure' when single-clicking
 
-    public override string[] GetPossibleDestinations()
-    {
-      if (Core.ML)
-        return m_MLDestinations;
-      return m_Dungeons;
-    }
+    public override string[] GetPossibleDestinations() => Core.ML ? m_MLDestinations : m_Dungeons;
 
     private static int GetRandomHue()
     {
@@ -89,4 +84,4 @@ namespace Server.Mobiles
       int version = reader.ReadInt();
     }
   }
-}
+}

Projects/Scripts/Mobiles/Townfolk/TownCrier.cs

@@ -4,7 +4,6 @@ using System.Text;
 using Server.Gumps;
 using Server.Items;
 using Server.Network;
-using Server.Prompts;
 
 namespace Server.Mobiles
 {
@@ -20,7 +19,7 @@ namespace Server.Mobiles
   {
     private static GlobalTownCrierEntryList m_Instance;
 
-    public static GlobalTownCrierEntryList Instance => m_Instance ?? (m_Instance = new GlobalTownCrierEntryList());
+    public static GlobalTownCrierEntryList Instance => m_Instance ??= new GlobalTownCrierEntryList();
 
     public bool IsEmpty => Entries == null || Entries.Count == 0;
 
@@ -50,8 +49,7 @@ namespace Server.Mobiles
 
     public TownCrierEntry AddEntry(string[] lines, TimeSpan duration)
     {
-      if (Entries == null)
-        Entries = new List<TownCrierEntry>();
+      Entries ??= new List<TownCrierEntry>();
 
       TownCrierEntry tce = new TownCrierEntry(lines, duration);
 
@@ -384,8 +382,7 @@ namespace Server.Mobiles
 
     public TownCrierEntry AddEntry(string[] lines, TimeSpan duration)
     {
-      if (Entries == null)
-        Entries = new List<TownCrierEntry>();
+      Entries ??= new List<TownCrierEntry>();
 
       TownCrierEntry tce = new TownCrierEntry(lines, duration);