Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Server/Menus/IMenu.cs

@@ -24,10 +24,10 @@ namespace Server.Menus
 {
   public interface IMenu
   {
-    int Serial{ get; }
+    Serial Serial{ get; }
     int EntryLength{ get; }
     void SendTo(NetState state);
     void OnCancel(NetState state);
     void OnResponse(NetState state, int index);
   }
-}
+}

Projects/Server/Menus/ItemListMenu.cs

@@ -20,7 +20,7 @@
 
 using Server.Network;
 
-namespace Server.Menus.ItemLists
+namespace Server.Menus
 {
   public class ItemListEntry
   {
@@ -40,8 +40,7 @@ namespace Server.Menus.ItemLists
 
   public class ItemListMenu : IMenu
   {
-    private static int m_NextSerial;
-    private int m_Serial;
+    private static Serial m_NextSerial;
 
     public ItemListMenu(string question, ItemListEntry[] entries)
     {
@@ -50,18 +49,18 @@ namespace Server.Menus.ItemLists
 
       do
       {
-        m_Serial = m_NextSerial++;
-        m_Serial &= 0x7FFFFFFF;
-      } while (m_Serial == 0);
+        Serial = m_NextSerial++;
+        Serial &= 0x7FFFFFFF;
+      } while (Serial == 0);
 
-      m_Serial = (int)((uint)m_Serial | 0x80000000);
+      Serial |= 0x80000000;
     }
 
     public string Question{ get; }
 
     public ItemListEntry[] Entries{ get; set; }
 
-    int IMenu.Serial => m_Serial;
+    public Serial Serial { get; private set; }
 
     int IMenu.EntryLength => Entries.Length;
 
@@ -76,7 +75,7 @@ namespace Server.Menus.ItemLists
     public void SendTo(NetState state)
     {
       state.AddMenu(this);
-      state.Send(new DisplayItemListMenu(this));
+      Packets.SendDisplayItemListMenu(state, this);
     }
   }
 }

Projects/Server/Menus/QuestionMenu.cs

@@ -20,12 +20,11 @@
 
 using Server.Network;
 
-namespace Server.Menus.Questions
+namespace Server.Menus
 {
   public class QuestionMenu : IMenu
   {
-    private static int m_NextSerial;
-    private int m_Serial;
+    private static Serial m_NextSerial;
 
     public QuestionMenu(string question, string[] answers)
     {
@@ -34,16 +33,16 @@ namespace Server.Menus.Questions
 
       do
       {
-        m_Serial = ++m_NextSerial;
-        m_Serial &= 0x7FFFFFFF;
-      } while (m_Serial == 0);
+        Serial = ++m_NextSerial;
+        Serial &= 0x7FFFFFFF;
+      } while (Serial == 0);
     }
 
     public string Question{ get; set; }
 
     public string[] Answers{ get; }
 
-    int IMenu.Serial => m_Serial;
+    public Serial Serial { get; private set; }
 
     int IMenu.EntryLength => Answers.Length;
 
@@ -58,7 +57,7 @@ namespace Server.Menus.Questions
     public void SendTo(NetState state)
     {
       state.AddMenu(this);
-      state.Send(new DisplayQuestionMenu(this));
+      Packets.SendDisplayQuestionMenu(state, this);
     }
   }
-}
+}