Updates Packets & Randomizer (#43)

* Fixes a bug with the main loop. Removes unnecessary optimizations for RDRand.

* WIP - Rewriting packets.

* Cleanup and updates README

* Converts more packets

* Fixes header

* Converts Effects packets.

* Forgot the send command

* Adds the start of containers packets.

* Adds message packets with caching

* Extends the send methods

* Starts to add Acquire methods

* Converted the packets

* Cleanup

* Cleanup

* Adds more packets

* Adds more packets

* Fixes clearing arrays from pool. Adds Mobile Incoming

* Converts more packets.

* Moves more packets

* Moves more packets

* Test compression

* Merges

* Migrating to an idiomatic syntax that also supports compression, and proxying.

* Optimize the stack alloc. Changes attributes

* Converted container packets

* Visual Studio doesn't auto save files. I am still getting used to subpar IDEs.

* Adds static packet caching. Will profile later. Converts more packets

* Fixes packets and changes how compression is configured

* WIP - Adds basics for Gumps. Not finished though.

* Fix file

* Fixes formatting

* Changed SpanWriter to be more idiomatic.

* Fixes Span vs RawSpan and missing stackallocs

* Converts over some more gumps

* WIP - Deletes 32bit support.

* Drops RDRand32 support.

* Fixes gump compilation

* Converting gump components

* Removes old huffman compression function

* Revert signature for backwards compatibility

* WIP - Converting more gump components

* Creates ArraySet for the strings. Updates AppendTo to reference that.

* Converts the maining gump components

* Cleans up gump components

* Cleans up directives

* Cleans up ArraySet and moves it. Adds null-coalescing-assignment

* Cleanup, Target Packets, and C# 8 changes.

* Removed OPL Packet

* World packets

* Fixing packet uses

* Cleans up code. Fixes packet uses in various places.

* More cleanup for packets

* Code cleanup

* Converts more packet uses and cleans up more code

* More code cleanup

* Finishes fixing the packets in Item

* Updates secure trade packets

* Updates core and gets it to compile.

* Moved packets to scripts. Fixed account handler use of packets

* Code cleanup

* Updates chat packets

* Code cleanuo

* Adds party packets, but need to implement them.

* Party packets WIP

* Finishes party packets

* Rearrange movement namespaces and classes

* Finishes plant packets

* Code Formatting

* Fixes moving effects

* Code cleanup, eliminates equipinfo

* Adds more packets. Fixes bugs with various packets.

* Finishes mahjon packets

* Fixes mahjong packet

* Code cleanup

* Finishes mahjong packets

* Adds Map packets

* Add multifacet maps and charts

* Cleans up some packets with UTF8

* Optimizes packets

* Cleans up more packets. Moves the MessageHelper

* Removes assistant support. Removes extended protocol. Incorporates MapUO packets as normal packets.

* Updates protocol extensions packet receiver

* Fixes a few bugs. Fixes a few more packets.

* Code cleanup and fixing more packets

* Fixes packet effects

* Cleaned up more code

* Buff Icon cleanup

* Removed unused constructors

* Code Cleanup. Adds BoatHS Packets

* Moves house files. Updates house foundation packets.

* Deployment cleanup

* Fixes:

* Code cleanup

* More code cleanup

* More code cleanup

* Cleaned up BaseHouse

* Enforces styling

* Converts foreach to linq where possible.

* Dont need that

* Goals/Readme updates

* Removes 32bit support at the highest level. Turns on HRT by default.

* Code cleanup. Fixes extended features packet.

* Fixes various bugs

* Code cleanup

* Code cleanup

* Code cleanup. Fixes gump X/Y assignment.

* Code cleanup using |= operator

* More code cleanup

* Cleanup

* Fixes spacing issues. Thanks Visual Studio. You suck.

* Compiler error

* Fixes NPE from RunUO 2.7

* Renames ScriptCompiler to AssemblyHandler. Fixes packets. Updates README

* Fixes more packets. Stupid trailing nulls.

* Fixes various bugs.

* Fixes for gumps

* Fixes more gump stuff. Going to split it out later since it is getting insane

* Recoded the gump writing

* WIP

* *Added output path of scripts project to dev branch
*Activated debugging in code

Projects/Server/Region.cs

@@ -21,15 +21,17 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Xml;
 using Server.Network;
 using Server.Targeting;
 
 namespace Server
 {
-  public enum MusicName
+  public enum MusicName : ushort
   {
-    Invalid = -1,
+    Invalid = 0xFFFF,
+    None = 0x1FFF,
     OldUlt01 = 0,
     Create1,
     DragFlit,
@@ -473,13 +475,7 @@ namespace Server
       List<Mobile> list = new List<Mobile>();
 
       for (int i = 0; i < Sectors?.Length; i++)
-      {
-        Sector sector = Sectors[i];
-
-        foreach (Mobile player in sector.Players)
-          if (player.Region.IsPartOf(this))
-            list.Add(player);
-      }
+        list.AddRange(Sectors[i].Players.Where(player => player.Region.IsPartOf(this)));
 
       return list;
     }
@@ -489,13 +485,7 @@ namespace Server
       int count = 0;
 
       for (int i = 0; i < Sectors?.Length; i++)
-      {
-        Sector sector = Sectors[i];
-
-        foreach (Mobile player in sector.Players)
-          if (player.Region.IsPartOf(this))
-            count++;
-      }
+        count += Sectors[i].Players.Count(player => player.Region.IsPartOf(this));
       return count;
     }
 
@@ -504,13 +494,7 @@ namespace Server
       List<Mobile> list = new List<Mobile>();
 
       for (int i = 0; i < Sectors?.Length; i++)
-      {
-        Sector sector = Sectors[i];
-
-        foreach (Mobile mobile in sector.Mobiles)
-          if (mobile.Region.IsPartOf(this))
-            list.Add(mobile);
-      }
+        list.AddRange(Sectors[i].Mobiles.Where(mobile => mobile.Region.IsPartOf(this)));
       return list;
     }
 
@@ -519,13 +503,7 @@ namespace Server
       int count = 0;
 
       for (int i = 0; i < Sectors?.Length; i++)
-      {
-        Sector sector = Sectors[i];
-
-        foreach (Mobile mobile in sector.Mobiles)
-          if (mobile.Region.IsPartOf(this))
-            count++;
-      }
+        count += Sectors[i].Mobiles.Count(mobile => mobile.Region.IsPartOf(this));
 
       return count;
     }
@@ -701,7 +679,8 @@ namespace Server
       {
         m.CheckLightLevels(false);
 
-        if (oldRegion == null || oldRegion.Music != newRegion.Music) m.Send(PlayMusic.GetInstance(newRegion.Music));
+        if (oldRegion == null || oldRegion.Music != newRegion.Music)
+          Packets.SendPlayMusic(m.NetState, newRegion.Music);
       }
 
       Region oldR = oldRegion;