warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes ValueStringBuilder dispose incorrectly (#1037)

Browse source
This commit is contained in:
Kamron Batman 2022-05-29 15:01:39 -07:00 • committed by GitHub
parent 3b7e3c2fb7
commit 1e6ab794fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/Server/Buffers/ValueStringBuilder.cs
View file

@ -347,12 +347,12 @@ public ref struct ValueStringBuilder
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Dispose()
{
char[] toReturn = _arrayToReturnToPool;
this = default; // for safety, to avoid using pooled array if this instance is erroneously appended to again
if (toReturn != null)
if (_arrayToReturnToPool != null)
{
ArrayPool.Return(toReturn);
ArrayPool.Return(_arrayToReturnToPool);
}
this = default; // for safety, to avoid using pooled array if this instance is erroneously appended to again
}
#nullable restore