From 26c1e399ba601cb52a3847e46a47c9f43f7d67d9 Mon Sep 17 00:00:00 2001 From: Kamron Batman <3953314+kamronbatman@users.noreply.github.com> Date: Sat, 28 Mar 2026 21:55:29 -0700 Subject: [PATCH] chore: Cleans workflows for NodeJS 24 (#2394) --- .github/workflows/build-test.yml | 24 +++++++++++++++++----- .github/workflows/build-tool-release.yml | 8 ++++---- .github/workflows/create-release.yml | 21 +++++++++---------- .github/workflows/post-release-discord.yml | 6 +----- .github/workflows/update-docs.yml | 4 ++-- azure-pipelines.yml | 17 +++++++++++++-- 6 files changed, 51 insertions(+), 29 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 87309b849..76fdc3035 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -3,8 +3,22 @@ name: Build on: push: branches: [main] + paths: + - '.config/dotnet-tools.json' + - 'Projects/**' + - 'Directory.Build.props' + - 'global.json' + - 'version.json' + - '*.slnx' pull_request: branches: [main] + paths: + - '.config/dotnet-tools.json' + - 'Projects/**' + - 'Directory.Build.props' + - 'global.json' + - 'version.json' + - '*.slnx' jobs: build-macos: @@ -20,11 +34,11 @@ jobs: name: MacOS 26 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 0 # avoid shallow clone so nbgv can do its work. - name: Install .NET - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@v5 with: global-json-file: global.json - name: Install Prerequisites @@ -32,7 +46,7 @@ jobs: brew update brew install icu4c libdeflate zstd argon2 - name: Set Library Path - run: echo "DYLD_LIBRARY_PATH=/opt/homebrew/lib:\$DYLD_LIBRARY_PATH" >> $GITHUB_ENV + run: echo "DYLD_LIBRARY_PATH=/opt/homebrew/lib:$DYLD_LIBRARY_PATH" >> $GITHUB_ENV - name: Build run: dotnet run --project Projects/BuildTool -- --config Release --skip-prereqs - name: Migration Changes @@ -82,11 +96,11 @@ jobs: - name: Install Prerequisites using apt run: apt-get update -y && apt-get install -y curl libicu-dev libdeflate-dev zstd libargon2-dev tzdata liburing-dev if: ${{ matrix.packageManager == 'apt' }} - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 0 # avoid shallow clone so nbgv can do its work. - name: Install .NET - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@v5 with: global-json-file: global.json - name: Build diff --git a/.github/workflows/build-tool-release.yml b/.github/workflows/build-tool-release.yml index 25c43df58..1039ce3e8 100644 --- a/.github/workflows/build-tool-release.yml +++ b/.github/workflows/build-tool-release.yml @@ -32,12 +32,12 @@ jobs: artifact: build-tool-linux-arm64 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 0 # Full clone required for Nerdbank.GitVersioning - name: Install .NET - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@v5 with: global-json-file: global.json @@ -54,7 +54,7 @@ jobs: shell: bash - name: Upload artifact - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 with: name: ${{ matrix.artifact }} path: publish/${{ matrix.artifact }} @@ -68,7 +68,7 @@ jobs: steps: - name: Download all artifacts - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v8 with: path: artifacts/ merge-multiple: true diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml index aa02e4489..a04ed63ab 100644 --- a/.github/workflows/create-release.yml +++ b/.github/workflows/create-release.yml @@ -10,27 +10,26 @@ jobs: name: Create Release runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: fetch-depth: 0 # avoid shallow clone so nbgv can do its work. token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} - name: Install .NET - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@v5 with: global-json-file: global.json - - name: Install NGBV - uses: dotnet/nbgv@master + - name: Compute version + uses: dotnet/nbgv@v0.5.1 id: nbgv - - name: Push git changes - uses: ad-m/github-push-action@master - with: - github_token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} - tags: true + - name: Push version tag + run: | + git tag ${{ steps.nbgv.outputs.Version }} + git push origin ${{ steps.nbgv.outputs.Version }} + env: + GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} - name: Create Release - id: create_release uses: softprops/action-gh-release@v2 with: - body: ${{ steps.changelog.outputs.clean_changelog }} tag_name: ${{ steps.nbgv.outputs.Version }} name: ${{ steps.nbgv.outputs.Version }} draft: false diff --git a/.github/workflows/post-release-discord.yml b/.github/workflows/post-release-discord.yml index 77e4fc02a..34f90e0f2 100644 --- a/.github/workflows/post-release-discord.yml +++ b/.github/workflows/post-release-discord.yml @@ -9,12 +9,8 @@ jobs: post-release-discord: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 # avoid shallow clone so nbgv can do its work. - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} - name: Post Release on Discord - uses: SethCohen/github-releases-to-discord@v1.15.0 + uses: SethCohen/github-releases-to-discord@v1.19.0 with: webhook_url: ${{ secrets.WEBHOOK_URL }} username: "Release Changelog" diff --git a/.github/workflows/update-docs.yml b/.github/workflows/update-docs.yml index c9a71f039..9ea51d261 100644 --- a/.github/workflows/update-docs.yml +++ b/.github/workflows/update-docs.yml @@ -9,9 +9,9 @@ jobs: update-docs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - - uses: actions/setup-python@v5 + - uses: actions/setup-python@v6 with: python-version: 3.x diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 7c61877a6..a16bb8fcc 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -1,18 +1,31 @@ name: 'Build' trigger: -- main + branches: + include: + - main + paths: + include: + - .config/dotnet-tools.json + - Projects/** + - Directory.Build.props + - global.json + - version.json + - '*.slnx' + - '*.sln' variables: DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true jobs: - job: BuildWindows - displayName: 'Windows Server 2022' + displayName: 'Windows Server 2025' pool: vmImage: 'windows-latest' steps: + - checkout: self + fetchDepth: 0 # avoid shallow clone so nbgv can do its work. - task: UseDotNet@2 displayName: 'Install .NET' inputs: