fix: Optimizes items to use default weights. (Part 1) (#2240)

Projects/UOContent/Items/Skill Items/Carpenter Items/TaxidermyKit.cs

@@ -22,7 +22,11 @@ public partial class TaxidermyKit : Item
     };
 
     [Constructible]
-    public TaxidermyKit() : base(0x1EBA) => Weight = 1.0;
+    public TaxidermyKit() : base(0x1EBA)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override int LabelNumber => 1041279; // a taxidermy kit
 

Projects/UOContent/Items/Skill Items/Musical Instruments/Tambourine.cs

@@ -6,5 +6,9 @@ namespace Server.Items;
 public partial class Tambourine : BaseInstrument
 {
     [Constructible]
-    public Tambourine() : base(0xE9D, 0x52, 0x53) => Weight = 1.0;
+    public Tambourine() : base(0xE9D, 0x52, 0x53)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }

Projects/UOContent/Items/Skill Items/Musical Instruments/TambourineTassel.cs

@@ -6,5 +6,9 @@ namespace Server.Items;
 public partial class TambourineTassel : BaseInstrument
 {
     [Constructible]
-    public TambourineTassel() : base(0xE9E, 0x52, 0x53) => Weight = 1.0;
+    public TambourineTassel() : base(0xE9E, 0x52, 0x53)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }

Projects/UOContent/Items/Skill Items/Specialized/GlassblowingBook.cs

@@ -7,7 +7,11 @@ namespace Server.Items;
 public partial class GlassblowingBook : Item
 {
     [Constructible]
-    public GlassblowingBook() : base(0xFF4) => Weight = 1.0;
+    public GlassblowingBook() : base(0xFF4)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override int LabelNumber => 1153528; // Crafting glass with Glassblowing
 

Projects/UOContent/Items/Skill Items/Specialized/MasonryBook.cs

@@ -7,7 +7,11 @@ namespace Server.Items;
 public partial class MasonryBook : Item
 {
     [Constructible]
-    public MasonryBook() : base(0xFBE) => Weight = 1.0;
+    public MasonryBook() : base(0xFBE)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override int LabelNumber => 1153527; // Making valuables with Stonecrafting
 

Projects/UOContent/Items/Skill Items/Specialized/SandMiningBook.cs

@@ -7,7 +7,11 @@ namespace Server.Items;
 public partial class SandMiningBook : Item
 {
     [Constructible]
-    public SandMiningBook() : base(0xFF4) => Weight = 1.0;
+    public SandMiningBook() : base(0xFF4)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
     public override int LabelNumber => 1153531; // Find Glass-Quality Sand
 
     public override void OnDoubleClick(Mobile from)

Projects/UOContent/Items/Skill Items/Specialized/StoneMiningBook.cs

@@ -7,7 +7,11 @@ namespace Server.Items;
 public partial class StoneMiningBook : Item
 {
     [Constructible]
-    public StoneMiningBook() : base(0xFBE) => Weight = 1.0;
+    public StoneMiningBook() : base(0xFBE)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override int LabelNumber => 1153530; // Mining For Quality Stone
 

Projects/UOContent/Items/Skill Items/Tailor Items/Misc/Scissors.cs

@@ -13,7 +13,11 @@ public interface IScissorable
 public partial class Scissors : Item
 {
     [Constructible]
-    public Scissors() : base(0xF9F) => Weight = 1.0;
+    public Scissors() : base(0xF9F)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override void OnDoubleClick(Mobile from)
     {

Projects/UOContent/Items/Skill Items/Thief/DisguiseKit.cs

@@ -17,7 +17,11 @@ public partial class DisguiseKit : Item
     public override int LabelNumber => 1041078; // a disguise kit
 
     [Constructible]
-    public DisguiseKit() : base(0xE05) => Weight = 1.0;
+    public DisguiseKit() : base(0xE05)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public bool ValidateUse(Mobile from)
     {

Projects/UOContent/Items/Skill Items/Tinkering/Clocks.cs

@@ -25,7 +25,11 @@ public partial class Clock : Item
     private static readonly DateTime WorldStart = new(1997, 9, 1);
 
     [Constructible]
-    public Clock(int itemID = 0x104B) : base(itemID) => Weight = 3.0;
+    public Clock(int itemID = 0x104B) : base(itemID)
+    {
+    }
+
+    public override double DefaultWeight => 3.0;
 
     public static DateTime ServerStart { get; private set; }
 

Projects/UOContent/Items/Skill Items/Tinkering/Utensils.cs

@@ -7,21 +7,33 @@ namespace Server.Items;
 public partial class Fork : Item
 {
     [Constructible]
-    public Fork() : base(0x9F4) => Weight = 1.0;
+    public Fork() : base(0x9F4)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class ForkLeft : Item
 {
     [Constructible]
-    public ForkLeft() : base(0x9F4) => Weight = 1.0;
+    public ForkLeft() : base(0x9F4)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class ForkRight : Item
 {
     [Constructible]
-    public ForkRight() : base(0x9F5) => Weight = 1.0;
+    public ForkRight() : base(0x9F5)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [Flippable(0x9F8, 0x9F9, 0x9C2, 0x9C3)]
@@ -29,21 +41,33 @@ public partial class ForkRight : Item
 public partial class Spoon : Item
 {
     [Constructible]
-    public Spoon() : base(0x9F8) => Weight = 1.0;
+    public Spoon() : base(0x9F8)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class SpoonLeft : Item
 {
     [Constructible]
-    public SpoonLeft() : base(0x9F8) => Weight = 1.0;
+    public SpoonLeft() : base(0x9F8)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class SpoonRight : Item
 {
     [Constructible]
-    public SpoonRight() : base(0x9F9) => Weight = 1.0;
+    public SpoonRight() : base(0x9F9)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [Flippable(0x9F6, 0x9F7, 0x9A5, 0x9A6)]
@@ -51,26 +75,42 @@ public partial class SpoonRight : Item
 public partial class Knife : Item
 {
     [Constructible]
-    public Knife() : base(0x9F6) => Weight = 1.0;
+    public Knife() : base(0x9F6)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class KnifeLeft : Item
 {
     [Constructible]
-    public KnifeLeft() : base(0x9F6) => Weight = 1.0;
+    public KnifeLeft() : base(0x9F6)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class KnifeRight : Item
 {
     [Constructible]
-    public KnifeRight() : base(0x9F7) => Weight = 1.0;
+    public KnifeRight() : base(0x9F7)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }
 
 [SerializationGenerator(0, false)]
 public partial class Plate : Item
 {
     [Constructible]
-    public Plate() : base(0x9D7) => Weight = 1.0;
+    public Plate() : base(0x9D7)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 }

Projects/UOContent/Items/Skill Items/Tools/DrawKnife.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class DrawKnife : BaseTool
 {
     [Constructible]
-    public DrawKnife() : base(0x10E4) => Weight = 1.0;
+    public DrawKnife() : base(0x10E4)
+    {
+    }
 
     [Constructible]
-    public DrawKnife(int uses) : base(uses, 0x10E4) => Weight = 1.0;
+    public DrawKnife(int uses) : base(uses, 0x10E4)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCarpentry.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/FlourSifter.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class FlourSifter : BaseTool
 {
     [Constructible]
-    public FlourSifter() : base(0x103E) => Weight = 1.0;
+    public FlourSifter() : base(0x103E)
+    {
+    }
 
     [Constructible]
-    public FlourSifter(int uses) : base(uses, 0x103E) => Weight = 1.0;
+    public FlourSifter(int uses) : base(uses, 0x103E)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCooking.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/Froe.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class Froe : BaseTool
 {
     [Constructible]
-    public Froe() : base(0x10E5) => Weight = 1.0;
+    public Froe() : base(0x10E5)
+    {
+    }
 
     [Constructible]
-    public Froe(int uses) : base(uses, 0x10E5) => Weight = 1.0;
+    public Froe(int uses) : base(uses, 0x10E5)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCarpentry.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/Inshave.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class Inshave : BaseTool
 {
     [Constructible]
-    public Inshave() : base(0x10E6) => Weight = 1.0;
+    public Inshave() : base(0x10E6)
+    {
+    }
 
     [Constructible]
-    public Inshave(int uses) : base(uses, 0x10E6) => Weight = 1.0;
+    public Inshave(int uses) : base(uses, 0x10E6)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCarpentry.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/MalletAndChisel.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class MalletAndChisel : BaseTool
 {
     [Constructible]
-    public MalletAndChisel() : base(0x12B3) => Weight = 1.0;
+    public MalletAndChisel() : base(0x12B3)
+    {
+    }
 
     [Constructible]
-    public MalletAndChisel(int uses) : base(uses, 0x12B3) => Weight = 1.0;
+    public MalletAndChisel(int uses) : base(uses, 0x12B3)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefMasonry.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/MapmakersPen.cs

@@ -8,10 +8,16 @@ namespace Server.Items;
 public partial class MapmakersPen : BaseTool
 {
     [Constructible]
-    public MapmakersPen() : base(0x0FBF) => Weight = 1.0;
+    public MapmakersPen() : base(0x0FBF)
+    {
+    }
 
     [Constructible]
-    public MapmakersPen(int uses) : base(uses, 0x0FBF) => Weight = 1.0;
+    public MapmakersPen(int uses) : base(uses, 0x0FBF)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCartography.CraftSystem;
 

Projects/UOContent/Items/Skill Items/Tools/MortarPestle.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class MortarPestle : BaseTool
 {
     [Constructible]
-    public MortarPestle() : base(0xE9B) => Weight = 1.0;
+    public MortarPestle() : base(0xE9B)
+    {
+    }
 
     [Constructible]
-    public MortarPestle(int uses) : base(uses, 0xE9B) => Weight = 1.0;
+    public MortarPestle(int uses) : base(uses, 0xE9B)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefAlchemy.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/RollingPin.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class RollingPin : BaseTool
 {
     [Constructible]
-    public RollingPin() : base(0x1043) => Weight = 1.0;
+    public RollingPin() : base(0x1043)
+    {
+    }
 
     [Constructible]
-    public RollingPin(int uses) : base(uses, 0x1043) => Weight = 1.0;
+    public RollingPin(int uses) : base(uses, 0x1043)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCooking.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/Scorp.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class Scorp : BaseTool
 {
     [Constructible]
-    public Scorp() : base(0x10E7) => Weight = 1.0;
+    public Scorp() : base(0x10E7)
+    {
+    }
 
     [Constructible]
-    public Scorp(int uses) : base(uses, 0x10E7) => Weight = 1.0;
+    public Scorp(int uses) : base(uses, 0x10E7)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCarpentry.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/ScribesPen.cs

@@ -8,10 +8,16 @@ namespace Server.Items;
 public partial class ScribesPen : BaseTool
 {
     [Constructible]
-    public ScribesPen() : base(0x0FBF) => Weight = 1.0;
+    public ScribesPen() : base(0x0FBF)
+    {
+    }
 
     [Constructible]
-    public ScribesPen(int uses) : base(uses, 0x0FBF) => Weight = 1.0;
+    public ScribesPen(int uses) : base(uses, 0x0FBF)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefInscription.CraftSystem;
 

Projects/UOContent/Items/Skill Items/Tools/Skillet.cs

@@ -7,10 +7,16 @@ namespace Server.Items;
 public partial class Skillet : BaseTool
 {
     [Constructible]
-    public Skillet() : base(0x97F) => Weight = 1.0;
+    public Skillet() : base(0x97F)
+    {
+    }
 
     [Constructible]
-    public Skillet(int uses) : base(uses, 0x97F) => Weight = 1.0;
+    public Skillet(int uses) : base(uses, 0x97F)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override int LabelNumber => 1044567; // skillet
 

Projects/UOContent/Items/Skill Items/Tools/SmoothingPlane.cs

@@ -8,10 +8,16 @@ namespace Server.Items;
 public partial class SmoothingPlane : BaseTool
 {
     [Constructible]
-    public SmoothingPlane() : base(0x1032) => Weight = 1.0;
+    public SmoothingPlane() : base(0x1032)
+    {
+    }
 
     [Constructible]
-    public SmoothingPlane(int uses) : base(uses, 0x1032) => Weight = 1.0;
+    public SmoothingPlane(int uses) : base(uses, 0x1032)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefCarpentry.CraftSystem;
 }

Projects/UOContent/Items/Skill Items/Tools/TinkerTools.cs

@@ -8,10 +8,16 @@ namespace Server.Items;
 public partial class TinkerTools : BaseTool
 {
     [Constructible]
-    public TinkerTools() : base(0x1EB8) => Weight = 1.0;
+    public TinkerTools() : base(0x1EB8)
+    {
+    }
 
     [Constructible]
-    public TinkerTools(int uses) : base(uses, 0x1EB8) => Weight = 1.0;
+    public TinkerTools(int uses) : base(uses, 0x1EB8)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefTinkering.CraftSystem;
 }
@@ -20,10 +26,16 @@ public partial class TinkerTools : BaseTool
 public partial class TinkersTools : BaseTool
 {
     [Constructible]
-    public TinkersTools() : base(0x1EBC) => Weight = 1.0;
+    public TinkersTools() : base(0x1EBC)
+    {
+    }
 
     [Constructible]
-    public TinkersTools(int uses) : base(uses, 0x1EBC) => Weight = 1.0;
+    public TinkersTools(int uses) : base(uses, 0x1EBC)
+    {
+    }
+
+    public override double DefaultWeight => 1.0;
 
     public override CraftSystem CraftSystem => DefTinkering.CraftSystem;
-}
+}