warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): Changes random source to use debut assert (#603)

Browse source 
Changes RNG to not crash in release mode with bad values.
This commit is contained in:
Kamron Batman 2021-05-15 20:15:22 -07:00 • committed by GitHub
parent 6866d51074
commit 3023254d87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Projects/Server/Random/BaseRandomSource.cs
View file

@ -14,6 +14,7 @@
*************************************************************************/
using System;
using System.Diagnostics;
using System.Numerics;
using System.Runtime.CompilerServices;
@ -42,12 +43,9 @@ namespace Server.Random
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int Next(int count)
{
if (count == 0)
{
throw new ArgumentOutOfRangeException(nameof(count), count, "count must not be 0");
}
Debug.Assert(count != 0, $"{nameof(count)} must not be 0");
if (count == 1 || count == -1)
if (count is -1 or 0 or 1)
{
return 0;
}
@ -73,12 +71,9 @@ namespace Server.Random
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public uint Next(uint count)
{
if (count == 0)
{
throw new ArgumentOutOfRangeException(nameof(count), count, "count must not be 0");
}
Debug.Assert(count != 0, $"{nameof(count)} must not be 0");
if (count == 1)
if (count is 0 or 1)
{
return 0;
}
@ -100,12 +95,9 @@ namespace Server.Random
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public long Next(long count)
{
if (count == 0)
{
throw new ArgumentOutOfRangeException(nameof(count), count, "count must not be 0");
}
Debug.Assert(count != 0, $"{nameof(count)} must not be 0");
if (count == 1 || count == -1)
if (count is -1 or 0 or 1)
{
return 0;
}