fix: Fixes targeting ground with spells (#1937)

Projects/UOContent/Spells/Eighth/EnergyVortex.cs

@@ -60,7 +60,7 @@ namespace Server.Spells.Eighth
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this, retryOnLos: true);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true, retryOnLos: true);
         }
     }
 }

Projects/UOContent/Spells/Fifth/BladeSpirits.cs

@@ -78,7 +78,7 @@ namespace Server.Spells.Fifth
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this, retryOnLos: true);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true, retryOnLos: true);
         }
     }
 }

Projects/UOContent/Spells/Fifth/PoisonField.cs

@@ -57,7 +57,7 @@ public class PoisonFieldSpell : MagerySpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }
 

Projects/UOContent/Spells/Fourth/ArchCure.cs

@@ -95,7 +95,7 @@ namespace Server.Spells.Fourth
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
 
         private bool AreaCanTarget(Mobile target, bool feluccaRules)

Projects/UOContent/Spells/Fourth/ArchProtection.cs

@@ -94,7 +94,7 @@ namespace Server.Spells.Fourth
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
 
         private static void AddEntry(Mobile m, int v)

Projects/UOContent/Spells/Fourth/FireField.cs

@@ -60,7 +60,7 @@ public class FireFieldSpell : MagerySpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }
 

Projects/UOContent/Spells/Mysticism/AnimatedWeaponSpell.cs

@@ -55,6 +55,6 @@ public class AnimatedWeaponSpell : MysticSpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }

Projects/UOContent/Spells/Mysticism/HailStormSpell.cs

@@ -73,7 +73,7 @@ public class HailStormSpell : MysticSpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 
     private static void PlayEffect(Point3D p, Map map)

Projects/UOContent/Spells/Mysticism/NetherCycloneSpell.cs

@@ -89,7 +89,7 @@ public class NetherCycloneSpell : MysticSpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 
     private static void PlayEffect(Point3D p, Map map)

Projects/UOContent/Spells/Ninjitsu/ShadowJump.cs

@@ -112,6 +112,6 @@ public class Shadowjump : NinjaSpell, ITargetingSpell<IPoint3D>
     public override void OnCast()
     {
         Caster.SendLocalizedMessage(1063088); // You prepare to perform a Shadowjump.
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }

Projects/UOContent/Spells/Seventh/ChainLightning.cs

@@ -99,7 +99,7 @@ namespace Server.Spells.Seventh
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
     }
 }

Projects/UOContent/Spells/Seventh/EnergyField.cs

@@ -71,7 +71,7 @@ public class EnergyFieldSpell : MagerySpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }
 

Projects/UOContent/Spells/Seventh/MassDispel.cs

@@ -76,7 +76,7 @@ namespace Server.Spells.Seventh
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
     }
 }

Projects/UOContent/Spells/Seventh/MeteorSwarm.cs

@@ -104,7 +104,7 @@ namespace Server.Spells.Seventh
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
     }
 }

Projects/UOContent/Spells/Sixth/MassCurse.cs

@@ -58,7 +58,7 @@ namespace Server.Spells.Sixth
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
     }
 }

Projects/UOContent/Spells/Sixth/ParalyzeField.cs

@@ -71,7 +71,7 @@ public class ParalyzeFieldSpell : MagerySpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }
 

Projects/UOContent/Spells/Sixth/Reveal.cs

@@ -55,7 +55,7 @@ namespace Server.Spells.Sixth
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
 
         // Reveal uses magery and detect hidden vs. hide and stealth

Projects/UOContent/Spells/Spellweaving/NatureFury.cs

@@ -70,7 +70,7 @@ namespace Server.Spells.Spellweaving
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
 
         private class InternalTimer : Timer

Projects/UOContent/Spells/Targeting/SpellTarget.cs

@@ -13,14 +13,18 @@ public class SpellTarget<T> : Target, ISpellTarget<T> where T : class, IPoint3D
 
     public SpellTarget(
         ITargetingSpell<T> spell,
-        TargetFlags flags = TargetFlags.None,
+        TargetFlags flags,
         bool retryOnLos = false
     ) : this(spell, false, flags, retryOnLos)
     {
     }
 
-    public SpellTarget(ITargetingSpell<T> spell, bool allowGround, TargetFlags flags = TargetFlags.None, bool retryOnLos = false)
-        : base(spell.TargetRange, allowGround, flags)
+    public SpellTarget(
+        ITargetingSpell<T> spell,
+        bool allowGround = false,
+        TargetFlags flags = TargetFlags.None,
+        bool retryOnLos = false
+    ) : base(spell.TargetRange, allowGround, flags)
     {
         _spell = spell;
         _retryOnLos = retryOnLos;

Projects/UOContent/Spells/Third/Teleport.cs

@@ -139,7 +139,7 @@ namespace Server.Spells.Third
 
         public override void OnCast()
         {
-            Caster.Target = new SpellTarget<IPoint3D>(this);
+            Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
         }
     }
 }

Projects/UOContent/Spells/Third/WallOfStone.cs

@@ -56,7 +56,7 @@ public class WallOfStoneSpell : MagerySpell, ITargetingSpell<IPoint3D>
 
     public override void OnCast()
     {
-        Caster.Target = new SpellTarget<IPoint3D>(this);
+        Caster.Target = new SpellTarget<IPoint3D>(this, allowGround: true);
     }
 }