C# 9 Cleanup (#325)

- [X] Removes EventArgs - not needed
- [X] Merges sequential checks
- [X] Removes redundant type declarations

Projects/UOContent/Spells/Bushido/Confidence.cs

@@ -5,15 +5,15 @@ namespace Server.Spells.Bushido
 {
     public class Confidence : SamuraiSpell
     {
-        private static readonly SpellInfo m_Info = new SpellInfo(
+        private static readonly SpellInfo m_Info = new(
             "Confidence",
             null,
             -1,
             9002
         );
 
-        private static readonly Dictionary<Mobile, Timer> m_Table = new Dictionary<Mobile, Timer>();
-        private static readonly Dictionary<Mobile, Timer> m_RegenTable = new Dictionary<Mobile, Timer>();
+        private static readonly Dictionary<Mobile, Timer> m_Table = new();
+        private static readonly Dictionary<Mobile, Timer> m_RegenTable = new();
 
         public Confidence(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
         {

Projects/UOContent/Spells/Bushido/CounterAttack.cs

@@ -6,14 +6,14 @@ namespace Server.Spells.Bushido
 {
     public class CounterAttack : SamuraiSpell
     {
-        private static readonly SpellInfo m_Info = new SpellInfo(
+        private static readonly SpellInfo m_Info = new(
             "CounterAttack",
             null,
             -1,
             9002
         );
 
-        private static readonly Dictionary<Mobile, Timer> m_Table = new Dictionary<Mobile, Timer>();
+        private static readonly Dictionary<Mobile, Timer> m_Table = new();
 
         public CounterAttack(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
         {

Projects/UOContent/Spells/Bushido/Evasion.cs

@@ -6,14 +6,14 @@ namespace Server.Spells.Bushido
 {
     public class Evasion : SamuraiSpell
     {
-        private static readonly SpellInfo m_Info = new SpellInfo(
+        private static readonly SpellInfo m_Info = new(
             "Evasion",
             null,
             -1,
             9002
         );
 
-        private static readonly Dictionary<Mobile, Timer> m_Table = new Dictionary<Mobile, Timer>();
+        private static readonly Dictionary<Mobile, Timer> m_Table = new();
 
         public Evasion(Mobile caster, Item scroll)
             : base(caster, scroll, m_Info)

Projects/UOContent/Spells/Bushido/HonorableExecution.cs

@@ -6,13 +6,13 @@ namespace Server.Spells.Bushido
     public class HonorableExecution : SamuraiMove
     {
         private static readonly Dictionary<Mobile, HonorableExecutionInfo> m_Table =
-            new Dictionary<Mobile, HonorableExecutionInfo>();
+            new();
 
         public override int BaseMana => 0;
         public override double RequiredSkill => 25.0;
 
         public override TextDefinition AbilityMessage =>
-            new TextDefinition(1063122); // You better kill your enemy with your next hit or you'll be rather sorry...
+            new(1063122); // You better kill your enemy with your next hit or you'll be rather sorry...
 
         public override double GetDamageScalar(Mobile attacker, Mobile defender)
         {

Projects/UOContent/Spells/Bushido/LightningStrike.cs

@@ -7,7 +7,7 @@ namespace Server.Spells.Bushido
         public override int BaseMana => 5;
         public override double RequiredSkill => 50.0;
 
-        public override TextDefinition AbilityMessage => new TextDefinition(1063167); // You prepare to strike quickly.
+        public override TextDefinition AbilityMessage => new(1063167); // You prepare to strike quickly.
 
         public override bool DelayedContext => true;
 

Projects/UOContent/Spells/Bushido/MomentumStrike.cs

@@ -8,7 +8,7 @@ namespace Server.Spells.Bushido
         public override double RequiredSkill => 70.0;
 
         public override TextDefinition AbilityMessage =>
-            new TextDefinition(1070757); // You prepare to strike two enemies with one blow.
+            new(1070757); // You prepare to strike two enemies with one blow.
 
         public override void OnHit(Mobile attacker, Mobile defender, int damage)
         {