warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: Migrate vendor management gumps to DynamicGump/StaticGump (#2431)

Browse source 
## Summary
Converts `ReclaimVendorGump`, `VendorInventoryGump`, and the five gumps in `VendorRentalGumps.cs` from legacy `Gump` to `DynamicGump` / `StaticGump<T>` with the static `DisplayTo` entry-point pattern.

| Gump | Target | Reason |
|---|---|---|
| `ReclaimVendorGump` | DynamicGump | Variable vendor inventory list count. |
| `VendorInventoryGump` | DynamicGump | Variable inventory list; keeps `from` (per-row button depends on owner check). |
| `BaseVendorRentalGump` (abstract) → `VendorRentalContractGump`, `VendorRentalOfferGump`, `RenterVendorRentalGump`, `LandlordVendorRentalGump` | DynamicGump | Layout has many conditional sections driven by `GumpType` enum. |
| `VendorRentalRefundGump` | StaticGump | Fixed layout; vendor name, shop name, refund amount in `BuildStrings` placeholders. |

All builder labels and string slots use `$"{value}"` interpolated-string-handler form for zero-allocation text.

Updates callers in `PlayerMobile`, `HouseSign`, `RentedVendor`, and `VendorRentalContract`.
This commit is contained in:
Kamron Batman 2026-05-03 10:19:12 -07:00 • committed by GitHub
parent 14f9d682e8
commit 402f3bc934
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 864 additions and 790 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Items/Deeds/VendorRentalContract.cs
View file

@ -195,7 +195,7 @@ public partial class VendorRentalContract : Item
{
if (from.InRange(this, 5))
{
from.SendGump(new VendorRentalContractGump(this, from), true);
VendorRentalContractGump.DisplayTo(from, this);
}
else
{
@ -231,7 +231,7 @@ public partial class VendorRentalContract : Item
{
if (target is VendorRentalContract contract && contract.IsUsableBy(from, true, true, true, true))
{
from.SendGump(new VendorRentalContractGump(contract, from), true);
VendorRentalContractGump.DisplayTo(from, contract);
}
}
}