fix(core): Fixes several serialization issues (#355)
- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases. - [X] Fixes an issue with dupe copying the savebuffer reference (ugh). - [X] Streamlines the IGenericWriter API to use better generics. - [X] Streamlines the IGenericReader API to use better generics. - [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects. - [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks. - [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading. - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states. - [X] Fixes an issue with serializing negative DateTime deltas. - [X] Fixes a potential issue with serializing non-UTC DateTime. Bumps release version
This commit is contained in:
parent
0888ab9b86
commit
4ddb3de026
162 changed files with 652 additions and 1045 deletions
|
|
@ -1380,10 +1380,10 @@ namespace Server.Engines.ConPVP
|
|||
{
|
||||
case 0:
|
||||
{
|
||||
Board = ip.ReadItem() as BRBoard;
|
||||
Board = ip.ReadEntity<BRBoard>();
|
||||
TeamName = ip.ReadString();
|
||||
Color = ip.ReadEncodedInt();
|
||||
m_Goal = ip.ReadItem() as BRGoal;
|
||||
m_Goal = ip.ReadEntity<BRGoal>();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -665,7 +665,7 @@ namespace Server.Engines.ConPVP
|
|||
{
|
||||
case 2:
|
||||
{
|
||||
Board = ip.ReadItem() as CTFBoard;
|
||||
Board = ip.ReadEntity<CTFBoard>();
|
||||
|
||||
goto case 1;
|
||||
}
|
||||
|
|
@ -679,7 +679,7 @@ namespace Server.Engines.ConPVP
|
|||
{
|
||||
Color = ip.ReadEncodedInt();
|
||||
|
||||
Flag = ip.ReadItem() as CTFFlag;
|
||||
Flag = ip.ReadEntity<CTFFlag>();
|
||||
Origin = ip.ReadPoint3D();
|
||||
break;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -311,7 +311,7 @@ namespace Server.Engines.ConPVP
|
|||
{
|
||||
case 0:
|
||||
{
|
||||
Board = ip.ReadItem() as DDBoard;
|
||||
Board = ip.ReadEntity<DDBoard>();
|
||||
TeamName = ip.ReadString();
|
||||
Color = ip.ReadEncodedInt();
|
||||
Origin = ip.ReadPoint3D();
|
||||
|
|
@ -481,8 +481,8 @@ namespace Server.Engines.ConPVP
|
|||
TeamInfo[i] = new DDTeamInfo(i, reader);
|
||||
}
|
||||
|
||||
PointA = reader.ReadItem() as DDWayPoint;
|
||||
PointB = reader.ReadItem() as DDWayPoint;
|
||||
PointA = reader.ReadEntity<DDWayPoint>();
|
||||
PointB = reader.ReadEntity<DDWayPoint>();
|
||||
|
||||
break;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -354,7 +354,7 @@ namespace Server.Engines.ConPVP
|
|||
{
|
||||
case 0:
|
||||
{
|
||||
m_Controller = reader.ReadItem() as KHController;
|
||||
m_Controller = reader.ReadEntity<KHController>();
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
@ -814,7 +814,8 @@ namespace Server.Engines.ConPVP
|
|||
writer.WriteEncodedInt(m_ScoreInterval);
|
||||
writer.Write(Duration);
|
||||
|
||||
writer.WriteItemList(Boards, true);
|
||||
Boards.Tidy();
|
||||
writer.Write(Boards);
|
||||
|
||||
writer.WriteEncodedInt(Hills.Length);
|
||||
for (var i = 0; i < Hills.Length; ++i)
|
||||
|
|
@ -843,12 +844,12 @@ namespace Server.Engines.ConPVP
|
|||
|
||||
Duration = reader.ReadTimeSpan();
|
||||
|
||||
Boards = reader.ReadStrongItemList<KHBoard>();
|
||||
Boards = reader.ReadEntityList<KHBoard>();
|
||||
|
||||
Hills = new HillOfTheKing[reader.ReadEncodedInt()];
|
||||
for (var i = 0; i < Hills.Length; ++i)
|
||||
{
|
||||
Hills[i] = reader.ReadItem() as HillOfTheKing;
|
||||
Hills[i] = reader.ReadEntity<HillOfTheKing>();
|
||||
}
|
||||
|
||||
TeamInfo = new KHTeamInfo[reader.ReadEncodedInt()];
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue