fix(core): Fixes several serialization issues (#355)

- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions

View file

@ -414,14 +414,16 @@ namespace Server.Items
writer.Write(2); // version
writer.Write(Guardians, true);
Guardians.Tidy();
writer.Write(Guardians);
writer.Write(Temporary);
writer.Write(Owner);
writer.Write(Level);
writer.WriteDeltaTime(DeleteTime);
writer.Write(m_Lifted, true);
m_Lifted.Tidy();
writer.Write(m_Lifted);
}
public override void Deserialize(IGenericReader reader)
@ -434,14 +436,14 @@ namespace Server.Items
{
case 2:
{
Guardians = reader.ReadStrongMobileList();
Guardians = reader.ReadEntityList<Mobile>();
Temporary = reader.ReadBool();
goto case 1;
}
case 1:
{
Owner = reader.ReadMobile();
Owner = reader.ReadEntity<Mobile>();
goto case 0;
}
@ -449,7 +451,7 @@ namespace Server.Items
{
Level = reader.ReadInt();
DeleteTime = reader.ReadDeltaTime();
m_Lifted = reader.ReadStrongItemList();
m_Lifted = reader.ReadEntityList<Item>();
if (version < 2)
{