warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): Fixes several serialization issues (#355)

Browse source 
- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Projects/UOContent/Items/Skill Items/Blacksmith Items/Misc/LargeForge.cs
View file

@ -71,8 +71,8 @@ namespace Server.Items
var version = reader.ReadInt();
m_Item = reader.ReadItem() as InternalItem;
m_Item2 = reader.ReadItem() as InternalItem2;
m_Item = reader.ReadEntity<InternalItem>();
m_Item2 = reader.ReadEntity<InternalItem2>();
}
[Forge]
@ -129,7 +129,7 @@ namespace Server.Items
var version = reader.ReadInt();
m_Item = reader.ReadItem() as LargeForgeWest;
m_Item = reader.ReadEntity<LargeForgeWest>();
}
}
@ -187,7 +187,7 @@ namespace Server.Items
var version = reader.ReadInt();
m_Item = reader.ReadItem() as LargeForgeWest;
m_Item = reader.ReadEntity<LargeForgeWest>();
}
}
}
@ -261,8 +261,8 @@ namespace Server.Items
var version = reader.ReadInt();
m_Item = reader.ReadItem() as InternalItem;
m_Item2 = reader.ReadItem() as InternalItem2;
m_Item = reader.ReadEntity<InternalItem>();
m_Item2 = reader.ReadEntity<InternalItem2>();
}
[Forge]
@ -319,7 +319,7 @@ namespace Server.Items
var version = reader.ReadInt();
m_Item = reader.ReadItem() as LargeForgeEast;
m_Item = reader.ReadEntity<LargeForgeEast>();
}
}
@ -377,7 +377,7 @@ namespace Server.Items
var version = reader.ReadInt();
m_Item = reader.ReadItem() as LargeForgeEast;
m_Item = reader.ReadEntity<LargeForgeEast>();
}
}
}

4
Projects/UOContent/Items/Skill Items/Carpenter Items/TaxidermyKit.cs
View file

@ -293,7 +293,7 @@ namespace Server.Items
{
case 1:
{
m_Hunter = reader.ReadMobile();
m_Hunter = reader.ReadEntity<Mobile>();
m_AnimalWeight = reader.ReadInt();
goto case 0;
}
@ -468,7 +468,7 @@ namespace Server.Items
{
case 1:
{
m_Hunter = reader.ReadMobile();
m_Hunter = reader.ReadEntity<Mobile>();
m_AnimalWeight = reader.ReadInt();
goto case 0;
}

2
Projects/UOContent/Items/Skill Items/Harvest Tools/BaseHarvestTool.cs
View file

@ -203,7 +203,7 @@ namespace Server.Items
{
case 1:
{
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
m_Quality = (ToolQuality)reader.ReadInt();
goto case 0;
}

2
Projects/UOContent/Items/Skill Items/Magical/Misc/RecallRune.cs
View file

@ -119,7 +119,7 @@ namespace Server.Items
{
case 1:
{
m_House = reader.ReadItem() as BaseHouse;
m_House = reader.ReadEntity<BaseHouse>();
goto case 0;
}
case 0:

2
Projects/UOContent/Items/Skill Items/Magical/Potions/Conflagration Potions/BaseConflagrationPotion.cs
View file

@ -249,7 +249,7 @@ namespace Server.Items
var version = reader.ReadInt();
From = reader.ReadMobile();
From = reader.ReadEntity<Mobile>();
m_End = reader.ReadDateTime();
m_MinDamage = reader.ReadInt();
m_MaxDamage = reader.ReadInt();

4
Projects/UOContent/Items/Skill Items/Magical/Runebook.cs
View file

@ -201,7 +201,7 @@ namespace Server.Items
}
case 2:
{
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
goto case 1;
}
case 1:
@ -476,7 +476,7 @@ namespace Server.Items
{
case 1:
{
House = reader.ReadItem() as BaseHouse;
House = reader.ReadEntity<BaseHouse>();
goto case 0;
}
case 0:

2
Projects/UOContent/Items/Skill Items/Magical/Spellbook.cs
View file

@ -929,7 +929,7 @@ namespace Server.Items
}
case 3:
{
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
goto case 2;
}
case 2:

2
Projects/UOContent/Items/Skill Items/Misc/RepairDeed.cs
View file

@ -218,7 +218,7 @@ namespace Server.Items
{
m_Skill = (RepairSkillType)reader.ReadInt();
m_SkillLevel = reader.ReadDouble();
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
break;
}

4
Projects/UOContent/Items/Skill Items/Musical Instruments/BaseInstrument.cs
View file

@ -517,7 +517,7 @@ namespace Server.Items
}
case 2:
{
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
m_Quality = (InstrumentQuality)reader.ReadEncodedInt();
m_Slayer = (SlayerName)reader.ReadEncodedInt();
@ -532,7 +532,7 @@ namespace Server.Items
}
case 1:
{
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
m_Quality = (InstrumentQuality)reader.ReadEncodedInt();
m_Slayer = (SlayerName)reader.ReadEncodedInt();

2
Projects/UOContent/Items/Skill Items/Thief/DisguisePersistance.cs
View file

@ -58,7 +58,7 @@ namespace Server.Items
for (var i = 0; i < count; ++i)
{
var m = reader.ReadMobile();
var m = reader.ReadEntity<Mobile>();
DisguiseTimers.CreateTimer(m, reader.ReadTimeSpan());
m.NameMod = reader.ReadString();
}

2
Projects/UOContent/Items/Skill Items/Tools/BaseTool.cs
View file

@ -204,7 +204,7 @@ namespace Server.Items
{
case 1:
{
m_Crafter = reader.ReadMobile();
m_Crafter = reader.ReadEntity<Mobile>();
m_Quality = (ToolQuality)reader.ReadInt();
goto case 0;
}