fix(core): Fixes several serialization issues (#355)

- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions

View file

@ -151,7 +151,7 @@ namespace Server.Items
{
case 1:
{
Placer = reader.ReadMobile();
Placer = reader.ReadEntity<Mobile>();
goto case 0;
}
@ -163,7 +163,7 @@ namespace Server.Items
for (var i = 0; i < count; ++i)
{
var item = reader.ReadItem();
var item = reader.ReadEntity<Item>();
if (item != null)
{
@ -288,7 +288,7 @@ namespace Server.Items
{
case 0:
{
m_Tree = reader.ReadItem() as HolidayTree;
m_Tree = reader.ReadEntity<HolidayTree>();
if (m_Tree == null)
{

View file

@ -148,7 +148,7 @@ namespace Server.Items
{
case 1:
{
m_Stone = reader.ReadItem<HouseRaffleStone>();
m_Stone = reader.ReadEntity<HouseRaffleStone>();
goto case 0;
}
@ -156,7 +156,7 @@ namespace Server.Items
{
m_PlotLocation = reader.ReadPoint3D();
m_Facet = reader.ReadMap();
m_AwardedTo = reader.ReadMobile();
m_AwardedTo = reader.ReadEntity<Mobile>();
break;
}

View file

@ -30,7 +30,7 @@ namespace Server.Items
case 1:
case 0:
{
From = reader.ReadMobile();
From = reader.ReadEntity<Mobile>();
Address = Utility.Intern(reader.ReadIPAddress());
Date = reader.ReadDateTime();
@ -640,7 +640,7 @@ namespace Server.Items
}
case 1:
{
Deed = reader.ReadItem<HouseRaffleDeed>();
Deed = reader.ReadEntity<HouseRaffleDeed>();
goto case 0;
}
@ -651,7 +651,7 @@ namespace Server.Items
m_Bounds = reader.ReadRect2D();
m_Facet = reader.ReadMap();
m_Winner = reader.ReadMobile();
m_Winner = reader.ReadEntity<Mobile>();
m_TicketPrice = reader.ReadInt();
m_Started = reader.ReadDateTime();

View file

@ -151,7 +151,7 @@ namespace Server.Items
writer.WriteEncodedInt(0); // version
writer.WriteItem(Organ);
writer.Write(Organ);
}
public override void Deserialize(IGenericReader reader)
@ -160,7 +160,7 @@ namespace Server.Items
var version = reader.ReadEncodedInt();
Organ = reader.ReadItem<PlagueBeastOrgan>();
Organ = reader.ReadEntity<PlagueBeastOrgan>();
}
}
}

View file

@ -90,7 +90,7 @@ namespace Server.Items
writer.WriteEncodedInt(0); // version
writer.WriteItemList(Components);
writer.Write(Components);
writer.Write(BrainHue);
writer.Write(Opened);
}
@ -101,7 +101,7 @@ namespace Server.Items
var version = reader.ReadEncodedInt();
Components = reader.ReadStrongItemList<PlagueBeastComponent>();
Components = reader.ReadEntityList<PlagueBeastComponent>();
BrainHue = reader.ReadInt();
Opened = reader.ReadBool();
}
@ -466,7 +466,7 @@ namespace Server.Items
var version = reader.ReadEncodedInt();
m_Gland = reader.ReadItem();
m_Gland = reader.ReadEntity<Item>();
}
}

View file

@ -358,7 +358,7 @@ namespace Server.Items
case 0:
{
m_Charges = Math.Min(reader.ReadEncodedInt(), MaxCharges);
Pet = (BaseCreature)reader.ReadMobile();
Pet = (BaseCreature)reader.ReadEntity<Mobile>();
PetName = reader.ReadString();
break;
}

View file

@ -361,7 +361,7 @@ namespace Server.Items
{
m_Charges = Math.Min(reader.ReadEncodedInt(), MaxCharges);
m_Inscription = reader.ReadString();
Bound = (BraceletOfBinding)reader.ReadItem();
Bound = (BraceletOfBinding)reader.ReadEntity<Item>();
break;
}
}

View file

@ -134,7 +134,7 @@ namespace Server.Items
var version = reader.ReadEncodedInt();
m_IsRewardItem = reader.ReadBool();
m_Fire = reader.ReadItem();
m_Fire = reader.ReadEntity<Item>();
}
}