fix(core): Fixes several serialization issues (#355)

- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions

View file

@ -1777,7 +1777,8 @@ namespace Server.Mobiles
writer.Write(EnergyDamage);
// Version 8
writer.Write(Owners, true);
Owners.Tidy();
writer.Write(Owners);
// Version 10
writer.Write(IsDeadPet);
@ -1798,7 +1799,8 @@ namespace Server.Mobiles
if (hasFriends)
{
writer.Write(Friends, true);
Friends.Tidy();
writer.Write(Friends);
}
// Version 14
@ -1887,8 +1889,8 @@ namespace Server.Mobiles
FightMode = (FightMode)reader.ReadInt();
m_Controlled = reader.ReadBool();
m_ControlMaster = reader.ReadMobile();
ControlTarget = reader.ReadMobile();
m_ControlMaster = reader.ReadEntity<Mobile>();
ControlTarget = reader.ReadEntity<Mobile>();
ControlDest = reader.ReadPoint3D();
m_ControlOrder = (OrderType)reader.ReadInt();
@ -1931,12 +1933,12 @@ namespace Server.Mobiles
if (version >= 4)
{
CurrentWayPoint = reader.ReadItem() as WayPoint;
CurrentWayPoint = reader.ReadEntity<WayPoint>();
}
if (version >= 5)
{
m_SummonMaster = reader.ReadMobile();
m_SummonMaster = reader.ReadEntity<Mobile>();
}
if (version >= 6)
@ -1968,7 +1970,7 @@ namespace Server.Mobiles
if (version >= 8)
{
Owners = reader.ReadStrongMobileList();
Owners = reader.ReadEntityList<Mobile>();
}
else
{
@ -2003,7 +2005,7 @@ namespace Server.Mobiles
if (version >= 13 && reader.ReadBool())
{
Friends = reader.ReadStrongMobileList();
Friends = reader.ReadEntityList<Mobile>();
}
else if (version < 13 && m_ControlOrder >= OrderType.Unfriend)
{