fix(core): Fixes several serialization issues (#355)

- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions

View file

@ -3005,7 +3005,7 @@ namespace Server.Mobiles
}
case 26:
{
AutoStabled = reader.ReadStrongMobileList();
AutoStabled = reader.ReadEntityList<Mobile>();
goto case 25;
}
@ -3139,7 +3139,7 @@ namespace Server.Mobiles
{
if (version < 13)
{
var paid = reader.ReadStrongItemList();
var paid = reader.ReadEntityList<Item>();
for (var i = 0; i < paid.Count; ++i)
{
@ -3182,7 +3182,7 @@ namespace Server.Mobiles
}
case 7:
{
PermaFlags = reader.ReadStrongMobileList();
PermaFlags = reader.ReadEntityList<Mobile>();
goto case 6;
}
case 6:
@ -3198,7 +3198,7 @@ namespace Server.Mobiles
case 4:
{
LastJusticeLoss = reader.ReadDeltaTime();
JusticeProtectors = reader.ReadStrongMobileList();
JusticeProtectors = reader.ReadEntityList<Mobile>();
goto case 3;
}
case 3:
@ -3318,7 +3318,8 @@ namespace Server.Mobiles
writer.Write(PeacedUntil);
writer.Write(AnkhNextUse);
writer.Write(AutoStabled, true);
AutoStabled.Tidy();
writer.Write(AutoStabled);
if (m_AcquiredRecipes == null)
{
@ -3401,14 +3402,16 @@ namespace Server.Mobiles
writer.Write(NpcGuildJoinTime);
writer.Write(NpcGuildGameTime);
writer.Write(PermaFlags, true);
PermaFlags.Tidy();
writer.Write(PermaFlags);
writer.Write(NextTailorBulkOrder);
writer.Write(NextSmithBulkOrder);
writer.WriteDeltaTime(LastJusticeLoss);
writer.Write(JusticeProtectors, true);
JusticeProtectors.Tidy();
writer.Write(JusticeProtectors);
writer.WriteDeltaTime(LastSacrificeGain);
writer.WriteDeltaTime(LastSacrificeLoss);