warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): Fixes several serialization issues (#355)

Browse source 
- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Projects/UOContent/Multis/Camps/BaseCamp.cs
View file

@ -159,8 +159,10 @@ namespace Server.Multis
writer.Write(0); // version
writer.Write(m_Items, true);
writer.Write(m_Mobiles, true);
m_Items.Tidy();
writer.Write(m_Items);
m_Mobiles.Tidy();
writer.Write(m_Mobiles);
writer.WriteDeltaTime(m_DecayTime);
}
@ -174,8 +176,8 @@ namespace Server.Multis
{
case 0:
{
m_Items = reader.ReadStrongItemList();
m_Mobiles = reader.ReadStrongMobileList();
m_Items = reader.ReadEntityList<Item>();
m_Mobiles = reader.ReadEntityList<Mobile>();
m_DecayTime = reader.ReadDeltaTime();
RefreshDecay(false);

2
Projects/UOContent/Multis/Camps/BrigandCamp.cs
View file

@ -176,7 +176,7 @@ namespace Server.Multis
{
case 0:
{
m_Prisoner = reader.ReadMobile();
m_Prisoner = reader.ReadEntity<Mobile>();
break;
}
}

2
Projects/UOContent/Multis/Camps/LizardmenCamp.cs
View file

@ -190,7 +190,7 @@ namespace Server.Multis
{
case 0:
{
m_Prisoner = reader.ReadMobile();
m_Prisoner = reader.ReadEntity<Mobile>();
break;
}
}

6
Projects/UOContent/Multis/Camps/OrcCamp.cs
View file

@ -192,13 +192,13 @@ namespace Server.Multis
{
case 1:
{
m_Prisoner = reader.ReadMobile();
m_Prisoner = reader.ReadEntity<Mobile>();
break;
}
case 0:
{
m_Prisoner = reader.ReadMobile();
reader.ReadItem();
m_Prisoner = reader.ReadEntity<Mobile>();
reader.ReadEntity<Item>();
break;
}
}

6
Projects/UOContent/Multis/Camps/RatCamp.cs
View file

@ -190,13 +190,13 @@ namespace Server.Multis
{
case 1:
{
m_Prisoner = reader.ReadMobile();
m_Prisoner = reader.ReadEntity<Mobile>();
break;
}
case 0:
{
m_Prisoner = reader.ReadMobile();
reader.ReadItem();
m_Prisoner = reader.ReadEntity<Mobile>();
reader.ReadEntity<Item>();
break;
}
}