fix(core): Fixes several serialization issues (#355)

- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions

View file

@ -908,7 +908,8 @@ namespace Server.Multis
writer.Write(SignHanger);
writer.Write(LastRevision);
writer.Write(Fixtures, true);
Fixtures.Tidy();
writer.Write(Fixtures);
CurrentState.Serialize(writer);
DesignState.Serialize(writer);
@ -926,7 +927,7 @@ namespace Server.Multis
case 5:
case 4:
{
Signpost = reader.ReadItem();
Signpost = reader.ReadEntity<Item>();
SignpostGraphic = reader.ReadInt();
goto case 3;
@ -939,7 +940,7 @@ namespace Server.Multis
}
case 2:
{
SignHanger = reader.ReadItem();
SignHanger = reader.ReadEntity<Item>();
goto case 1;
}
@ -965,7 +966,7 @@ namespace Server.Multis
}
LastRevision = reader.ReadInt();
Fixtures = reader.ReadStrongItemList();
Fixtures = reader.ReadEntityList<Item>();
m_Current = new DesignState(this, reader);
m_Design = new DesignState(this, reader);