Cleanup & Fixes for .NET 5 (#309)

- [X] Fixes several bugs
- [X] Updates more ordinal issues
- [X] Cleans up the code a bit
- [X] Turns classes static that should have been
- [X] Changes TcpServer.Instances to a HashSet

Bumps release version
This commit is contained in:
Kamron Batman 2020-11-15 10:03:50 -08:00 committed by GitHub
parent 4ad8811df2
commit 525cda5413
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
266 changed files with 1348 additions and 1800 deletions

View file

@ -42,7 +42,9 @@ namespace Server.Engines.MLQuests
while ((line = sr.ReadLine()) != null)
{
if (line.Length == 0 || line.StartsWith("#"))
line = line.Trim();
if (line.Length == 0 || line.StartsWith("#", StringComparison.Ordinal))
{
continue;
}
@ -176,8 +178,8 @@ namespace Server.Engines.MLQuests
EventSink.QuestGumpRequest += EventSink_QuestGumpRequest;
}
[Usage("MLQuestsInfo")]
[Description("Displays general information about the ML quest system, or a quest by type name.")]
[Usage("MLQuestsInfo"),
Description("Displays general information about the ML quest system, or a quest by type name.")]
public static void MLQuestsInfo_OnCommand(CommandEventArgs e)
{
var m = e.Mobile;
@ -202,8 +204,8 @@ namespace Server.Engines.MLQuests
m.SendMessage("Number of active instances: {0}", quest.Instances.Count);
}
[Usage("SaveQuest <type> [saveEnabled=true]")]
[Description("Allows serialization for a specific quest to be turned on or off.")]
[Usage("SaveQuest <type> [saveEnabled=true]"),
Description("Allows serialization for a specific quest to be turned on or off.")]
public static void SaveQuest_OnCommand(CommandEventArgs e)
{
var m = e.Mobile;
@ -235,8 +237,8 @@ namespace Server.Engines.MLQuests
}
}
[Usage("SaveAllQuests [saveEnabled=true]")]
[Description("Allows serialization for all quests to be turned on or off.")]
[Usage("SaveAllQuests [saveEnabled=true]"),
Description("Allows serialization for all quests to be turned on or off.")]
public static void SaveAllQuests_OnCommand(CommandEventArgs e)
{
var m = e.Mobile;
@ -264,8 +266,8 @@ namespace Server.Engines.MLQuests
}
}
[Usage("InvalidQuestItems")]
[Description("Provides an overview of all quest items not located in the top-level of a player's backpack.")]
[Usage("InvalidQuestItems"),
Description("Provides an overview of all quest items not located in the top-level of a player's backpack.")]
public static void InvalidQuestItems_OnCommand(CommandEventArgs e)
{
var m = e.Mobile;