Cleanup & Fixes for .NET 5 (#309)

- [X] Fixes several bugs
- [X] Updates more ordinal issues
- [X] Cleans up the code a bit
- [X] Turns classes static that should have been
- [X] Changes TcpServer.Instances to a HashSet

Bumps release version
This commit is contained in:
Kamron Batman 2020-11-15 10:03:50 -08:00 • committed by GitHub
parent 4ad8811df2
commit 525cda5413
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
266 changed files with 1348 additions and 1800 deletions

View file

@ -1,3 +1,5 @@
using System;
namespace Server.Items
{
public enum HeadType
@ -79,17 +81,17 @@ namespace Server.Items
if (format != null)
{
if (format.StartsWith("the head of "))
if (format.StartsWith("the head of ", StringComparison.Ordinal))
{
format = format.Substring("the head of ".Length);
format = format.Substring(14); // "the head of|..."
}
if (format.EndsWith(", taken in a duel"))
if (format.EndsWith(", taken in a duel", StringComparison.Ordinal))
{
format = format.Substring(0, format.Length - ", taken in a duel".Length);
HeadType = HeadType.Duel;
}
else if (format.EndsWith(", taken in a tournament"))
else if (format.EndsWith(", taken in a tournament", StringComparison.Ordinal))
{
format = format.Substring(0, format.Length - ", taken in a tournament".Length);
HeadType = HeadType.Tournament;