Cleanup & Fixes for .NET 5 (#309)

- [X] Fixes several bugs
- [X] Updates more ordinal issues
- [X] Cleans up the code a bit
- [X] Turns classes static that should have been
- [X] Changes TcpServer.Instances to a HashSet

Bumps release version
This commit is contained in:
Kamron Batman 2020-11-15 10:03:50 -08:00 • committed by GitHub
parent 4ad8811df2
commit 525cda5413
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
266 changed files with 1348 additions and 1800 deletions

View file

@ -4,6 +4,7 @@ using Server.Network;
namespace Server
{
#pragma warning disable CA1052
public class LightCycle
{
public const int DayLevel = 0;
@ -20,9 +21,8 @@ namespace Server
{
m_LevelOverride = value;
for (var i = 0; i < TcpServer.Instances.Count; ++i)
foreach (var ns in TcpServer.Instances)
{
var ns = TcpServer.Instances[i];
var m = ns.Mobile;
m?.CheckLightLevels(false);
@ -38,8 +38,7 @@ namespace Server
CommandSystem.Register("GlobalLight", AccessLevel.GameMaster, Light_OnCommand);
}
[Usage("GlobalLight <value>")]
[Description("Sets the current global light level.")]
[Usage("GlobalLight <value>"), Description("Sets the current global light level.")]
private static void Light_OnCommand(CommandEventArgs e)
{
if (e.Length >= 1)
@ -111,12 +110,9 @@ namespace Server
protected override void OnTick()
{
for (var i = 0; i < TcpServer.Instances.Count; ++i)
foreach (var ns in TcpServer.Instances)
{
var ns = TcpServer.Instances[i];
var m = ns.Mobile;
m?.CheckLightLevels(false);
ns.Mobile?.CheckLightLevels(false);
}
}
}
@ -139,4 +135,5 @@ namespace Server
}
}
}
#pragma warning restore CA1052
}