Adds style cop (#109)

This commit is contained in:
Kamron Batman 2020-04-26 00:16:02 -07:00 committed by GitHub
parent 3e715bcb60
commit 556a17aba8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1725 changed files with 33831 additions and 38046 deletions

View file

@ -53,7 +53,7 @@ namespace Server.Engines.MLQuests
m_Timer = Timer.DelayCall(TimeSpan.FromSeconds(5), TimeSpan.FromSeconds(5), Slice);
}
public MLQuest Quest{ get; set; }
public MLQuest Quest { get; set; }
public IQuestGiver Quester
{
@ -65,13 +65,13 @@ namespace Server.Engines.MLQuests
}
}
public Type QuesterType{ get; private set; }
public Type QuesterType { get; private set; }
public PlayerMobile Player{ get; set; }
public PlayerMobile Player { get; set; }
public MLQuestContext PlayerContext => MLQuestSystem.GetOrCreateContext(Player);
public DateTime Accepted{ get; set; }
public DateTime Accepted { get; set; }
public bool ClaimReward
{
@ -91,7 +91,7 @@ namespace Server.Engines.MLQuests
set => SetFlag(MLQuestInstanceFlags.Failed, value);
}
public BaseObjectiveInstance[] Objectives{ get; set; }
public BaseObjectiveInstance[] Objectives { get; set; }
public bool SkipReportBack => TextDefinition.IsNullOrEmpty(Quest.CompletionMessage);
@ -158,8 +158,7 @@ namespace Server.Engines.MLQuests
* For quests that require collections, this is done later when
* the player double clicks the quester.
*/
if (!Removed && SkipReportBack && !Quest.RequiresCollection
) // An OnQuestCompleted can potentially have removed this instance already
if (!Removed && SkipReportBack && !Quest.RequiresCollection) // An OnQuestCompleted can potentially have removed this instance already
ContinueReportBack(false);
}
}
@ -198,7 +197,7 @@ namespace Server.Engines.MLQuests
}
}
if (Quest.ObjectiveType == ObjectiveType.All && hasAnyFails || !hasAnyLeft)
if ((Quest.ObjectiveType == ObjectiveType.All && hasAnyFails) || !hasAnyLeft)
Fail();
if (!hasAnyLeft)