Adds style cop (#109)

This commit is contained in:
Kamron Batman 2020-04-26 00:16:02 -07:00 • committed by GitHub
parent 3e715bcb60
commit 556a17aba8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1725 changed files with 33831 additions and 38046 deletions

View file

@ -5,7 +5,7 @@ namespace Server.Engines.Quests.Collector
{
public class CollectorQuest : QuestSystem
{
private static Type[] m_TypeReferenceTable =
private static readonly Type[] m_TypeReferenceTable =
{
typeof(DontOfferConversation),
typeof(DeclineConversation),

View file

@ -241,7 +241,7 @@ namespace Server.Engines.Quests.Collector
public class FullEndConversation : QuestConversation
{
private bool m_Logged;
private readonly bool m_Logged;
public FullEndConversation(bool logged) => m_Logged = logged;

View file

@ -54,7 +54,7 @@ namespace Server.Engines.Quests.Collector
private class InternalTarget : Target
{
private EnchantedPaints m_Paints;
private readonly EnchantedPaints m_Paints;
public InternalTarget(EnchantedPaints paints) : base(-1, false, TargetFlags.None)
{
@ -78,7 +78,7 @@ namespace Server.Engines.Quests.Collector
if (obj?.Completed != false)
return;
if (targeted is Mobile)
{
CaptureResponse response = obj.CaptureImage(
@ -89,27 +89,27 @@ namespace Server.Engines.Quests.Collector
switch (response)
{
case CaptureResponse.Valid:
{
player.SendLocalizedMessage(
1055125); // The enchanted paints swirl for a moment then an image begins to take shape. *Click*
player.AddToBackpack(new PaintedImage(image));
{
player.SendLocalizedMessage(
1055125); // The enchanted paints swirl for a moment then an image begins to take shape. *Click*
player.AddToBackpack(new PaintedImage(image));
break;
}
break;
}
case CaptureResponse.AlreadyDone:
{
player.SendAsciiMessage(0x2C,
"You have already captured the image of this creature");
{
player.SendAsciiMessage(0x2C,
"You have already captured the image of this creature");
break;
}
break;
}
case CaptureResponse.Invalid:
{
player.SendLocalizedMessage(
1055124); // You have no interest in capturing the image of this creature.
{
player.SendLocalizedMessage(
1055124); // You have no interest in capturing the image of this creature.
break;
}
break;
}
}
}
else

View file

@ -66,13 +66,13 @@ namespace Server.Engines.Quests.Collector
Y = y;
}
public int Figurine{ get; }
public int Figurine { get; }
public Type Type{ get; }
public Type Type { get; }
public int Name => Figurine < 0x4000 ? 1020000 + Figurine : 1078872 + Figurine;
public int X{ get; }
public int Y{ get; }
public int X { get; }
public int Y { get; }
public static ImageTypeInfo Get(ImageType image)
{
@ -88,7 +88,7 @@ namespace Server.Engines.Quests.Collector
for (int i = 0; i < m_Table.Length; i++)
m_ImageTypeList[i] = (ImageType)i;
}
ImageType[] array = m_ImageTypeList.ToArray();
Utility.Shuffle(array);
return array.Take(count).ToArray();

View file

@ -197,7 +197,7 @@ namespace Server.Engines.Quests.Collector
private class DisassembleEntry : ContextMenuEntry
{
private Obsidian m_Obsidian;
private readonly Obsidian m_Obsidian;
public DisassembleEntry(Obsidian obsidian) : base(6142) => m_Obsidian = obsidian;
@ -217,7 +217,7 @@ namespace Server.Engines.Quests.Collector
private class InternalTarget : Target
{
private Obsidian m_Obsidian;
private readonly Obsidian m_Obsidian;
public InternalTarget(Obsidian obsidian) : base(-1, false, TargetFlags.None) => m_Obsidian = obsidian;

View file

@ -152,7 +152,6 @@ namespace Server.Engines.Quests.Collector
{
if (player.FindBankNoCreate()?.ConsumeTotal(typeof(Gold), 10) == true)
obj.Complete();
else
player.SendLocalizedMessage(
1055108); // You don't have enough gold to buy the sheet music.

View file

@ -33,7 +33,7 @@ namespace Server.Engines.Quests.Collector
AddItem(new Boots(0x452));
AddItem(new FullApron(0x455));
HairItemID = 0x203B; //ShortHair
HairItemID = 0x203B; // ShortHair
HairHue = 0x455;
}