Adds style cop (#109)

This commit is contained in:
Kamron Batman 2020-04-26 00:16:02 -07:00 • committed by GitHub
parent 3e715bcb60
commit 556a17aba8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1725 changed files with 33831 additions and 38046 deletions

View file

@ -32,7 +32,6 @@ namespace Server.Engines.Quests.Naturalist
AddItem(new LongPants(0x59B));
AddItem(new Boots());
Utility.AssignRandomHair(this);
Utility.AssignRandomFacialHair(this, HairHue);
}
@ -44,7 +43,7 @@ namespace Server.Engines.Quests.Naturalist
StudyNestsObjective study = qs.FindObjective<StudyNestsObjective>();
if (study == null)
return;
if (!study.Completed)
{
PlaySound(0x41F);

View file

@ -21,7 +21,7 @@ namespace Server.Engines.Quests.Naturalist
new Rectangle2D(5672, 1857, 6, 20))
};
private Rectangle2D[] m_Rects;
private readonly Rectangle2D[] m_Rects;
private NestArea(bool special, params Rectangle2D[] rects)
{
@ -31,7 +31,7 @@ namespace Server.Engines.Quests.Naturalist
public static int NonSpecialCount => m_Areas.Count(area => !area.Special);
public bool Special{ get; }
public bool Special { get; }
public int ID
{

View file

@ -8,7 +8,7 @@ namespace Server.Engines.Quests.Naturalist
{
private NestArea m_CurrentNest;
private List<NestArea> m_StudiedNests = new List<NestArea>();
private readonly List<NestArea> m_StudiedNests = new List<NestArea>();
private DateTime m_StudyBegin;
private StudyState m_StudyState;
@ -16,7 +16,7 @@ namespace Server.Engines.Quests.Naturalist
public override int MaxProgress => NestArea.NonSpecialCount;
public bool StudiedSpecialNest{ get; private set; }
public bool StudiedSpecialNest { get; private set; }
public override bool GetTimerEvent() => true;

View file

@ -5,7 +5,7 @@ namespace Server.Engines.Quests.Naturalist
{
public class StudyOfSolenQuest : QuestSystem
{
private static Type[] m_TypeReferenceTable =
private static readonly Type[] m_TypeReferenceTable =
{
typeof(StudyNestsObjective),
typeof(ReturnToNaturalistObjective),
@ -35,7 +35,7 @@ namespace Server.Engines.Quests.Naturalist
public override int Picture => 0x15C7;
public Naturalist Naturalist{ get; private set; }
public Naturalist Naturalist { get; private set; }
public override void ChildDeserialize(IGenericReader reader)
{