Adds style cop (#109)

This commit is contained in:
Kamron Batman 2020-04-26 00:16:02 -07:00 • committed by GitHub
parent 3e715bcb60
commit 556a17aba8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1725 changed files with 33831 additions and 38046 deletions

View file

@ -9,12 +9,12 @@ namespace Server.Guilds
{
public class GuildRosterGump : BaseGuildListGump<PlayerMobile>
{
private static InfoField<PlayerMobile>[] m_Fields =
private static readonly InfoField<PlayerMobile>[] m_Fields =
{
new InfoField<PlayerMobile>(1062955, 130, NameComparer.Instance), //Name
new InfoField<PlayerMobile>(1062956, 80, RankComparer.Instance), //Rank
new InfoField<PlayerMobile>(1062952, 80, LastOnComparer.Instance), //Last On
new InfoField<PlayerMobile>(1062953, 150, TitleComparer.Instance) //Guild Title
new InfoField<PlayerMobile>(1062955, 130, NameComparer.Instance), // Name
new InfoField<PlayerMobile>(1062956, 80, RankComparer.Instance), // Rank
new InfoField<PlayerMobile>(1062952, 80, LastOnComparer.Instance), // Last On
new InfoField<PlayerMobile>(1062953, 150, TitleComparer.Instance) // Guild Title
};
public GuildRosterGump(PlayerMobile pm, Guild g) : this(pm, g, LastOnComparer.Instance)
@ -130,14 +130,10 @@ namespace Server.Guilds
{
pm.SendLocalizedMessage(1063051, targ.Name); // ~1_val~ is already a member of a guild.
}
else if (targ.HasGump<BaseGuildGump>() || targ.HasGump<CreateGuildGump>()
) //TODO: Check message if CreateGuildGump Open
else if (targ.HasGump<BaseGuildGump>() || targ.HasGump<CreateGuildGump>()) // TODO: Check message if CreateGuildGump Open
{
pm.SendLocalizedMessage(1063052, targ.Name); // ~1_val~ is currently considering another guild invitation.
}
#region Factions
else if (targ.Young && guildFaction != null)
{
pm.SendLocalizedMessage(1070766); // You cannot invite a young player to your faction-aligned guild.
@ -156,9 +152,6 @@ namespace Server.Guilds
// OSI does this quite strangely, so we'll just do it this way
pm.SendMessage("That person is quitting their faction and so you may not recruit them.");
}
#endregion
else
{
pm.SendLocalizedMessage(1063053, targ.Name); // You invite ~1_val~ to join your guild.
@ -166,8 +159,6 @@ namespace Server.Guilds
}
}
#region Comparers
private class NameComparer : IComparer<PlayerMobile>
{
public static readonly IComparer<PlayerMobile> Instance = new NameComparer();
@ -244,7 +235,5 @@ namespace Server.Guilds
return x.GuildRank.Rank.CompareTo(y.GuildRank.Rank);
}
}
#endregion
}
}