Adds style cop (#109)

This commit is contained in:
Kamron Batman 2020-04-26 00:16:02 -07:00 • committed by GitHub
parent 3e715bcb60
commit 556a17aba8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1725 changed files with 33831 additions and 38046 deletions

View file

@ -86,13 +86,11 @@ namespace Server.Mobiles
int version = reader.ReadInt();
}
#region Area Peace
private DateTime m_NextPeace;
public void AreaPeace()
{
if (Combatant == null || Deleted || !Alive || m_NextPeace > DateTime.UtcNow || 0.1 < Utility.RandomDouble())
if (Combatant == null || Deleted || !Alive || m_NextPeace > DateTime.UtcNow || Utility.RandomDouble() > 0.1)
return;
TimeSpan duration = TimeSpan.FromSeconds(Utility.RandomMinMax(20, 80));
@ -118,15 +116,11 @@ namespace Server.Mobiles
m?.PeacedUntil < DateTime.UtcNow && !m.Hidden && m.AccessLevel == AccessLevel.Player &&
CanBeHarmful(m);
#endregion
#region Undress
private DateTime m_NextUndress;
public void AreaUndress()
{
if (Combatant == null || Deleted || !Alive || m_NextUndress > DateTime.UtcNow || 0.005 < Utility.RandomDouble())
if (Combatant == null || Deleted || !Alive || m_NextUndress > DateTime.UtcNow || Utility.RandomDouble() > 0.005)
return;
foreach (Mobile m in GetMobilesInRange(RangePerception))
@ -153,7 +147,5 @@ namespace Server.Mobiles
if (item?.Movable == true)
m.PlaceInBackpack(item);
}
#endregion
}
}

View file

@ -79,13 +79,11 @@ namespace Server.Mobiles
int version = reader.ReadInt();
}
#region Peace
private DateTime m_NextPeace;
public void Peace(Mobile target)
{
if (target == null || Deleted || !Alive || m_NextPeace > DateTime.UtcNow || 0.1 < Utility.RandomDouble())
if (target == null || Deleted || !Alive || m_NextPeace > DateTime.UtcNow || Utility.RandomDouble() > 0.1)
return;
if (target is PlayerMobile p && p.PeacedUntil < DateTime.UtcNow && !p.Hidden && CanBeHarmful(p))
@ -101,17 +99,13 @@ namespace Server.Mobiles
m_NextPeace = DateTime.UtcNow + TimeSpan.FromSeconds(10);
}
#endregion
#region Suppress
private static Dictionary<Mobile, Timer> m_Suppressed = new Dictionary<Mobile, Timer>();
private static readonly Dictionary<Mobile, Timer> m_Suppressed = new Dictionary<Mobile, Timer>();
private DateTime m_NextSuppress;
public void Suppress(Mobile target)
{
if (target == null || m_Suppressed.ContainsKey(target) || Deleted || !Alive ||
m_NextSuppress > DateTime.UtcNow || 0.1 < Utility.RandomDouble())
m_NextSuppress > DateTime.UtcNow || Utility.RandomDouble() > 0.1)
return;
TimeSpan delay = TimeSpan.FromSeconds(Utility.RandomMinMax(20, 80));
@ -155,7 +149,7 @@ namespace Server.Mobiles
private class AnimateTimer : Timer
{
private int m_Count;
private Mobile m_Owner;
private readonly Mobile m_Owner;
public AnimateTimer(Mobile owner, int count) : base(TimeSpan.Zero, TimeSpan.FromSeconds(1.25))
{
@ -172,15 +166,11 @@ namespace Server.Mobiles
}
}
#endregion
#region Undress
private DateTime m_NextUndress;
public void Undress(Mobile target)
{
if (target == null || Deleted || !Alive || m_NextUndress > DateTime.UtcNow || 0.005 < Utility.RandomDouble())
if (target == null || Deleted || !Alive || m_NextUndress > DateTime.UtcNow || Utility.RandomDouble() > 0.005)
return;
if (target.Player && target.Female && !target.Hidden && CanBeHarmful(target))
@ -206,15 +196,11 @@ namespace Server.Mobiles
m.PlaceInBackpack(item);
}
#endregion
#region Provoke
private DateTime m_NextProvoke;
public void Provoke(Mobile target)
{
if (target == null || Deleted || !Alive || m_NextProvoke > DateTime.UtcNow || 0.05 < Utility.RandomDouble())
if (target == null || Deleted || !Alive || m_NextProvoke > DateTime.UtcNow || Utility.RandomDouble() > 0.05)
return;
foreach (Mobile m in GetMobilesInRange(RangePerception))
@ -235,7 +221,5 @@ namespace Server.Mobiles
m_NextProvoke = DateTime.UtcNow + TimeSpan.FromSeconds(10);
}
#endregion
}
}

View file

@ -29,8 +29,8 @@ namespace Server.Mobiles
SetSkill(SkillName.Tactics, 65.1, 90.0); // Unknown
SetSkill(SkillName.Wrestling, 65.1, 85.0); // Unknown
Fame = 12500; //Unknown
Karma = 12500; //Unknown
Fame = 12500; // Unknown
Karma = 12500; // Unknown
VirtualArmor = 24;
PackItem(new Log(Utility.RandomMinMax(23, 34)));
@ -58,7 +58,7 @@ namespace Server.Mobiles
public override void GenerateLoot()
{
AddLoot(LootPack.Average); //Unknown
AddLoot(LootPack.Average); // Unknown
}
public override void Serialize(IGenericWriter writer)

View file

@ -25,10 +25,10 @@ namespace Server.Mobiles
SetResistance(ResistanceType.Poison, 30, 40);
SetResistance(ResistanceType.Energy, 30, 40);
//SetSkill( SkillName.Meditation, Unknown );
//SetSkill( SkillName.EvalInt, Unknown );
//SetSkill( SkillName.Magery, Unknown );
//SetSkill( SkillName.Poisoning, Unknown );
// SetSkill( SkillName.Meditation, Unknown );
// SetSkill( SkillName.EvalInt, Unknown );
// SetSkill( SkillName.Magery, Unknown );
// SetSkill( SkillName.Poisoning, Unknown );
SetSkill(SkillName.Anatomy, 0);
SetSkill(SkillName.MagicResist, 60.6, 67.5);
SetSkill(SkillName.Tactics, 86.9, 103.6);

View file

@ -29,7 +29,6 @@ namespace Server.Mobiles
SetSkill(SkillName.Tactics, 100.7, 102.8);
SetSkill(SkillName.MagicResist, 104.3, 116.3);
Fame = 20000;
Karma = -20000;
}