Adds style cop (#109)

This commit is contained in:
Kamron Batman 2020-04-26 00:16:02 -07:00 committed by GitHub
parent 3e715bcb60
commit 556a17aba8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1725 changed files with 33831 additions and 38046 deletions

View file

@ -6,9 +6,9 @@ using Server.Targeting;
namespace Server.SkillHandlers
{
public class Discordance
public static class Discordance
{
private static Dictionary<Mobile, DiscordanceInfo> m_Table = new Dictionary<Mobile, DiscordanceInfo>();
private static readonly Dictionary<Mobile, DiscordanceInfo> m_Table = new Dictionary<Mobile, DiscordanceInfo>();
public static void Initialize()
{
@ -88,12 +88,12 @@ namespace Server.SkillHandlers
private class DiscordanceInfo
{
public Mobile m_Creature;
public int m_Effect;
public readonly Mobile m_Creature;
public readonly int m_Effect;
public bool m_Ending;
public DateTime m_EndTime;
public Mobile m_From;
public List<object> m_Mods;
public readonly Mobile m_From;
public readonly List<object> m_Mods;
public Timer m_Timer;
public DiscordanceInfo(Mobile from, Mobile creature, int effect, List<object> mods)
@ -141,7 +141,7 @@ namespace Server.SkillHandlers
public class DiscordanceTarget : Target
{
private BaseInstrument m_Instrument;
private readonly BaseInstrument m_Instrument;
public DiscordanceTarget(Mobile from, BaseInstrument inst) : base(
BaseInstrument.GetBardRange(from, SkillName.Discordance), false, TargetFlags.None) =>
@ -159,13 +159,13 @@ namespace Server.SkillHandlers
}
else if (target is Mobile targ)
{
if (targ == from || targ is BaseCreature bc &&
if (targ == from || (targ is BaseCreature bc &&
(bc.BardImmune || !from.CanBeHarmful(bc, false)) &&
bc.ControlMaster != from)
bc.ControlMaster != from))
{
from.SendLocalizedMessage(1049535); // A song of discord would have no effect on that.
}
else if (m_Table.ContainsKey(targ)) //Already discorded
else if (m_Table.ContainsKey(targ)) // Already discorded
{
from.SendLocalizedMessage(1049537); // Your target is already in discord.
}