Code Cleanup & Fixes Warnings (#74)

This commit is contained in:
Kamron Batman 2020-01-18 14:56:45 -08:00 committed by GitHub
parent e11d1f3ad9
commit 57b14ad690
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
143 changed files with 2960 additions and 3427 deletions

View file

@ -30,7 +30,6 @@ using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Connections;
using Server.Accounting;
using Server.Diagnostics;
using Server.Gumps;
using Server.HuePickers;
using Server.Items;
@ -302,8 +301,7 @@ namespace Server.Network
public void AddMenu(IMenu menu)
{
if (Menus == null)
Menus = new List<IMenu>();
Menus ??= new List<IMenu>();
if (Menus.Count < MenuCap)
Menus.Add(menu);
@ -331,8 +329,7 @@ namespace Server.Network
public void AddHuePicker(HuePicker huePicker)
{
if (HuePickers == null)
HuePickers = new List<HuePicker>();
HuePickers ??= new List<HuePicker>();
if (HuePickers.Count < HuePickerCap)
HuePickers.Add(huePicker);
@ -360,8 +357,7 @@ namespace Server.Network
public void AddGump(Gump gump)
{
if (Gumps == null)
Gumps = new List<Gump>();
Gumps ??= new List<Gump>();
if (Gumps.Count < GumpCap)
Gumps.Add(gump);
@ -435,7 +431,9 @@ namespace Server.Network
ConnectedOn = DateTime.UtcNow;
Console.WriteLine("Client: {0}: Connected. [{1} Online]", this, Instances.Count);
_ = ProcessRecvs(pump);
#pragma warning disable 4014
ProcessRecvs(pump);
#pragma warning restore 4014
CreatedCallback?.Invoke(this);
}
@ -566,9 +564,7 @@ namespace Server.Network
private int m_Disposing;
public bool IsDisposing { get => m_Disposing != 0;
private set => m_Disposing = value ? 1 : 0;
}
public bool IsDisposing => m_Disposing != 0;
public virtual void Dispose()
{