Code Cleanup & Fixes Warnings (#74)

This commit is contained in:
Kamron Batman 2020-01-18 14:56:45 -08:00 • committed by GitHub
parent e11d1f3ad9
commit 57b14ad690
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
143 changed files with 2960 additions and 3427 deletions

View file

@ -44,7 +44,7 @@ namespace Server
dataFile.Write(buffer, 0, length);
if (indexBuffer == null) indexBuffer = new byte[20];
indexBuffer ??= new byte[20];
indexBuffer[0] = (byte)typeCode;
indexBuffer[1] = (byte)(typeCode >> 8);
@ -77,4 +77,4 @@ namespace Server
return length;
}
}
}
}

View file

@ -167,8 +167,7 @@ namespace Server
while (size > 0)
{
if (buffered.buffer == null)
buffered.buffer = ArrayPool<byte>.Shared.Rent(bufferSize);
buffered.buffer ??= ArrayPool<byte>.Shared.Rent(bufferSize);
byte[] page = buffered.buffer; // buffer page
int pageSpace = page.Length - buffered.length; // available bytes in page

View file

@ -66,7 +66,7 @@ namespace Server
}
else
{
if (writeCallback == null) writeCallback = OnWrite;
writeCallback ??= OnWrite;
fileStream.BeginWrite(chunk.Buffer, chunk.Offset, chunk.Size, writeCallback, chunk);
}
@ -78,7 +78,7 @@ namespace Server
fileStream.EndWrite(asyncResult);
chunk.Commit();
chunk?.Commit();
}
public override void Write(byte[] buffer, int offset, int size)
@ -117,4 +117,4 @@ namespace Server
fileStream.SetLength(value);
}
}
}
}

View file

@ -103,7 +103,7 @@ namespace Server
idx.Write(m.m_TypeRef);
idx.Write(m.Serial);
idx.Write(start);
idx.Write((int)(m.SaveBuffer.Position));
idx.Write((int)m.SaveBuffer.Position);
m.SaveBuffer.WriteTo(bin);
m.FreeCache();
@ -201,7 +201,7 @@ namespace Server
idx.Write(0); //guilds have no typeid
idx.Write(guild.Id);
idx.Write(start);
idx.Write((int)(guild.SaveBuffer.Position));
idx.Write((int)guild.SaveBuffer.Position);
guild.SaveBuffer.WriteTo(bin);
}