warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Fixes packet length checks (#953)

Browse source 
Fixes an issue with DropReq where an old client was sending in 14 bytes, but the server was expecting 15 bytes.

To fix this we introduced a new packet handler, `ContainerGridPacketHandler` and changed the code to determine the length of the packet dynamically using `GetLength(NetState)`.

Also fixed throttling so dropped packets are properly skipped.
This commit is contained in:
Kamron Batman 2022-03-04 12:32:25 -08:00 • committed by GitHub
parent 1f4162288e
commit 58b907d39e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 1077 additions and 1126 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/Server/Network/Packets/IncomingMobilePackets.cs
View file

@ -27,7 +27,7 @@ public static class IncomingMobilePackets
IncomingPackets.Register(0x6F, 0, true, SecureTrade);
}
public static void RenameRequest(NetState state, CircularBufferReader reader, ref int packetLength)
public static void RenameRequest(NetState state, CircularBufferReader reader, int packetLength)
{
var from = state.Mobile;
var targ = World.FindMobile((Serial)reader.ReadUInt32());
@ -38,7 +38,7 @@ public static class IncomingMobilePackets
}
}
public static void MobileNameRequest(NetState state, CircularBufferReader reader, ref int packetLength)
public static void MobileNameRequest(NetState state, CircularBufferReader reader, int packetLength)
{
var m = World.FindMobile((Serial)reader.ReadUInt32());
@ -48,7 +48,7 @@ public static class IncomingMobilePackets
}
}
public static void ProfileReq(NetState state, CircularBufferReader reader, ref int packetLength)
public static void ProfileReq(NetState state, CircularBufferReader reader, int packetLength)
{
int type = reader.ReadByte();
var serial = (Serial)reader.ReadUInt32();
@ -88,7 +88,7 @@ public static class IncomingMobilePackets
}
}
public static void SecureTrade(NetState state, CircularBufferReader reader, ref int packetLength)
public static void SecureTrade(NetState state, CircularBufferReader reader, int packetLength)
{
switch (reader.ReadByte())
{