warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes packet length checks (#953)

Browse source 
Fixes an issue with DropReq where an old client was sending in 14 bytes, but the server was expecting 15 bytes.

To fix this we introduced a new packet handler, `ContainerGridPacketHandler` and changed the code to determine the length of the packet dynamically using `GetLength(NetState)`.

Also fixed throttling so dropped packets are properly skipped.
This commit is contained in:
Kamron Batman 2022-03-04 12:32:25 -08:00 • committed by GitHub
parent 1f4162288e
commit 58b907d39e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 1077 additions and 1126 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Engines/Chat/ChatPackets.cs
View file

@ -27,7 +27,7 @@ namespace Server.Engines.Chat
IncomingPackets.Register(0xB3, 0, true, ChatAction);
}
public static void OpenChatWindowRequest(NetState state, CircularBufferReader reader, ref int packetLength)
public static void OpenChatWindowRequest(NetState state, CircularBufferReader reader, int packetLength)
{
var from = state.Mobile;
@ -48,7 +48,7 @@ namespace Server.Engines.Chat
ChatUser.AddChatUser(from, chatName);
}
public static void ChatAction(NetState state, CircularBufferReader reader, ref int packetLength)
public static void ChatAction(NetState state, CircularBufferReader reader, int packetLength)
{
if (!ChatSystem.Enabled)
{

2
Projects/UOContent/Engines/ML Quests/Gumps/RaceChangeGump.cs
View file

@ -193,7 +193,7 @@ namespace Server.Engines.MLQuests.Gumps
return false;
}
private static void RaceChangeReply(NetState state, CircularBufferReader reader, ref int packetLength)
private static void RaceChangeReply(NetState state, CircularBufferReader reader, int packetLength)
{
if (!m_Pending.TryGetValue(state, out var raceChangeState))
{

2
Projects/UOContent/Engines/UltimaStore/UltimaStorePackets.cs
View file

@ -9,7 +9,7 @@ namespace Server.Engines.UltimaStore
IncomingPackets.Register(0xFA, 1, true, UltimaStoreOpenRequest);
}
public static void UltimaStoreOpenRequest(NetState state, CircularBufferReader reader, ref int packetLength)
public static void UltimaStoreOpenRequest(NetState state, CircularBufferReader reader, int packetLength)
{
state.Mobile.SendMessage("Ultima Store is not currently available.");
}