warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes packet length checks (#953)

Browse source 
Fixes an issue with DropReq where an old client was sending in 14 bytes, but the server was expecting 15 bytes.

To fix this we introduced a new packet handler, `ContainerGridPacketHandler` and changed the code to determine the length of the packet dynamically using `GetLength(NetState)`.

Also fixed throttling so dropped packets are properly skipped.
This commit is contained in:
Kamron Batman 2022-03-04 12:32:25 -08:00 • committed by GitHub
parent 1f4162288e
commit 58b907d39e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 1077 additions and 1126 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Projects/UOContent/Misc/HardwareInfo.cs
View file

@ -141,7 +141,7 @@ namespace Server
}
}
public static void OnReceive(NetState state, CircularBufferReader reader, ref int packetLength)
public static void OnReceive(NetState state, CircularBufferReader reader, int packetLength)
{
reader.ReadByte(); // 1: <4.0.1a, 2>=4.0.1a

6
Projects/UOContent/Misc/PacketThrottles.cs
View file

@ -38,8 +38,8 @@ namespace Server.Network
}
else
{
Delays[0x03] = 5; // Speech
Delays[0xAD] = 5; // Speech
Delays[0x03] = 25; // Speech
Delays[0xAD] = 25; // Speech
Delays[0x75] = 500; // Rename request
}
@ -141,7 +141,7 @@ namespace Server.Network
return true;
}
if (Core.TickCount < ns.GetPacketDelay(packetID) + Delays[packetID])
if (Core.TickCount < ns.GetPacketTime(packetID) + Delays[packetID])
{
drop = true;
return false;