warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes packet length checks (#953)

Browse source 
Fixes an issue with DropReq where an old client was sending in 14 bytes, but the server was expecting 15 bytes.

To fix this we introduced a new packet handler, `ContainerGridPacketHandler` and changed the code to determine the length of the packet dynamically using `GetLength(NetState)`.

Also fixed throttling so dropped packets are properly skipped.
This commit is contained in:
Kamron Batman 2022-03-04 12:32:25 -08:00 • committed by GitHub
parent 1f4162288e
commit 58b907d39e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 1077 additions and 1126 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Projects/UOContent/Network/ConnectUO.cs
View file

@ -70,7 +70,7 @@ namespace Server.Network
}
}
public static void PollInfo(NetState ns, CircularBufferReader reader, ref int packetLength)
public static void PollInfo(NetState state, CircularBufferReader reader, int packetLength)
{
var version = reader.ReadByte();
@ -83,21 +83,21 @@ namespace Server.Network
if (!span.SequenceEqual(_token))
{
ns.Disconnect("Invalid token sent for ConnectUO");
state.Disconnect("Invalid token sent for ConnectUO");
return;
}
}
}
ns.LogInfo($"ConnectUO (v{version}) is requesting stats.");
state.LogInfo($"ConnectUO (v{version}) is requesting stats.");
if (version > ConnectUOProtocolVersion)
{
Utility.PushColor(ConsoleColor.Yellow);
ns.LogInfo("Warning! ConnectUO (v{version}) is newer than what is supported.");
state.LogInfo("Warning! ConnectUO (v{version}) is newer than what is supported.");
Utility.PopColor();
}
ns.SendServerPollInfo();
state.SendServerPollInfo();
}
public static void SendServerPollInfo(this NetState ns)