warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes packet length checks (#953)

Browse source 
Fixes an issue with DropReq where an old client was sending in 14 bytes, but the server was expecting 15 bytes.

To fix this we introduced a new packet handler, `ContainerGridPacketHandler` and changed the code to determine the length of the packet dynamically using `GetLength(NetState)`.

Also fixed throttling so dropped packets are properly skipped.
This commit is contained in:
Kamron Batman 2022-03-04 12:32:25 -08:00 • committed by GitHub
parent 1f4162288e
commit 58b907d39e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 1077 additions and 1126 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Projects/UOContent/Network/ProtocolExtensions.cs
View file

@ -21,11 +21,11 @@ namespace Server.Network
{
var packetHandlers = new PacketHandler[0x100];
void DecodeBundledPacket(NetState state, CircularBufferReader reader, ref int packetLength)
void DecodeBundledPacket(NetState state, CircularBufferReader reader, int packetLength)
{
int cmd = reader.ReadByte();
PacketHandler ph = cmd >= 0 && cmd < packetHandlers.Length ? packetHandlers[cmd] : null;
PacketHandler ph = packetHandlers[cmd];
if (ph == null)
{
@ -43,7 +43,7 @@ namespace Server.Network
}
else
{
ph.OnReceive(state, reader, ref packetLength);
ph.OnReceive(state, reader, packetLength);
}
}