warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes packet length checks (#953)

Browse source 
Fixes an issue with DropReq where an old client was sending in 14 bytes, but the server was expecting 15 bytes.

To fix this we introduced a new packet handler, `ContainerGridPacketHandler` and changed the code to determine the length of the packet dynamically using `GetLength(NetState)`.

Also fixed throttling so dropped packets are properly skipped.
This commit is contained in:
Kamron Batman 2022-03-04 12:32:25 -08:00 • committed by GitHub
parent 1f4162288e
commit 58b907d39e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 1077 additions and 1126 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/UOContent/Network/UOGateway.cs
View file

@ -33,9 +33,9 @@ namespace Server.Network
}
}
public static void QueryCompactShardStats(NetState ns, CircularBufferReader reader, ref int packetLength)
public static void QueryCompactShardStats(NetState state, CircularBufferReader reader, int packetLength)
{
ns.SendCompactShardStats(
state.SendCompactShardStats(
(uint)(Core.TickCount / 1000),
TcpServer.Instances.Count - 1, // Shame if you modify this!
World.Items.Count,
@ -44,10 +44,10 @@ namespace Server.Network
);
}
public static void QueryExtendedShardStats(NetState ns, CircularBufferReader reader, ref int packetLength)
public static void QueryExtendedShardStats(NetState state, CircularBufferReader reader, int packetLength)
{
const long ticksInHour = 1000 * 60 * 60;
ns.SendExtendedShardStats(
state.SendExtendedShardStats(
ServerList.ServerName,
(int)(Core.TickCount / ticksInHour),
TcpServer.Instances.Count - 1, // Shame if you modify this!