warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updates networking to make pipe writer awaitable (#290)

Browse source 
- [X] Updates result so it is preallocated
- [X] Updates PipeWriter so it is awaitable
- [X] Simplifies NetState code to match changes
- [X] Adds a byte for empty checking so incoming/outgoing can have full pipes.

Bumps release version
This commit is contained in:
Kamron Batman 2020-10-27 11:22:07 -07:00 • committed by GitHub
parent 99bfff40df
commit 5f7e4bf050
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 292 additions and 210 deletions
Download patch file Download diff file Expand all files Collapse all files

54
Projects/Server.Tests/Network/Packets/Old/Outgoing/AccountPacketTests.cs
View file

@ -19,13 +19,13 @@ namespace Server.Tests.Network
secondMobile.RawName = null;
var account = new MockAccount(new[] { firstMobile, null, secondMobile });
var oldPacket = new ChangeCharacter(account).Compile();
var expected = new ChangeCharacter(account).Compile();
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendChangeCharacter(ns, account);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), oldPacket);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -37,8 +37,8 @@ namespace Server.Tests.Network
Packets.SendClientVersionRequest(ns);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -49,8 +49,8 @@ namespace Server.Tests.Network
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendCharacterDeleteResult(ns, DeleteResultType.BadRequest);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -61,8 +61,8 @@ namespace Server.Tests.Network
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendPopupMessage(ns, PMMessage.LoginSyncError);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Theory]
@ -83,8 +83,8 @@ namespace Server.Tests.Network
var expected = new SupportedFeatures(ns).Compile();
Packets.SendSupportedFeature(ns);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -104,8 +104,8 @@ namespace Server.Tests.Network
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendLoginConfirmation(ns, m);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -116,8 +116,8 @@ namespace Server.Tests.Network
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendLoginComplete(ns);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -134,8 +134,8 @@ namespace Server.Tests.Network
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendCharacterListUpdate(ns, acct);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -160,8 +160,8 @@ namespace Server.Tests.Network
Packets.SendCharacterList(ns);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -185,8 +185,8 @@ namespace Server.Tests.Network
Packets.SendCharacterList(ns);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -198,8 +198,8 @@ namespace Server.Tests.Network
using var ns = PacketTestUtilities.CreateTestNetState();
Packets.SendAccountLoginRejected(ns, reason);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -217,8 +217,8 @@ namespace Server.Tests.Network
Packets.SendAccountLoginAck(ns);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
[Fact]
@ -233,8 +233,8 @@ namespace Server.Tests.Network
Packets.SendPlayServerAck(ns, si, authId);
ns.SendPipe.Reader.TryRead(out var buffer);
AssertThat.Equal(buffer.GetSpan(0), expected);
var result = ns.SendPipe.Reader.TryRead();
AssertThat.Equal(result.Buffer[0].AsSpan(0), expected);
}
}
}