cleanup: Fixes bugs and cleans up code (#660)

This commit is contained in:
Kamron Batman 2021-07-19 20:49:59 -07:00 • committed by GitHub
parent 1de0b656a9
commit 679e8100f4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
99 changed files with 160 additions and 346 deletions

View file

@ -816,7 +816,7 @@ namespace Server.Mobiles
}
else
{
AddItem(Utility.RandomBool() ? (Item)new LongPants(GetRandomHue()) : new ShortPants(GetRandomHue()));
AddItem(Utility.RandomBool() ? new LongPants(GetRandomHue()) : new ShortPants(GetRandomHue()));
}
PackGold(100, 200);
@ -875,7 +875,7 @@ namespace Server.Mobiles
new BuyItemState(
buyItem.Name,
cont.Serial,
disp?.Serial ?? (Serial)0x7FC0FFEE,
disp?.Serial ?? 0x7FC0FFEE,
buyItem.Price,
buyItem.Amount,
buyItem.ItemID,

View file

@ -38,7 +38,7 @@ namespace Server.Mobiles
{
base.InitOutfit();
AddItem(Utility.RandomBool() ? new QuarterStaff() : (Item)new ShepherdsCrook());
AddItem(Utility.RandomBool() ? new QuarterStaff() : new ShepherdsCrook());
}
public override void AddCustomContextEntries(Mobile from, List<ContextMenuEntry> list)

View file

@ -58,7 +58,7 @@ namespace Server.Mobiles
AddItem(new MetalKiteShield { Hue = Utility.RandomNondyedHue() });
AddItem(Utility.RandomBool() ? (Item)new Boots() : new ThighBoots());
AddItem(Utility.RandomBool() ? new Boots() : new ThighBoots());
PackGold(100, 200);
}

View file

@ -38,7 +38,7 @@ namespace Server.Mobiles
AddItem(
Utility.RandomBool()
? (Item)new SkullCap(Utility.RandomNeutralHue())
? new SkullCap(Utility.RandomNeutralHue())
: new Bandana(Utility.RandomNeutralHue())
);

View file

@ -800,7 +800,7 @@ namespace Server.Mobiles
{
--buttonID;
if (buttonID >= 0 && buttonID < m_Entries.Length)
if (buttonID < m_Entries.Length)
{
m_Barkeeper.EndChangeTitle(m_From, m_Entries[buttonID].m_Title, m_Entries[buttonID].m_Vendor);
}