warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Fixes crashing due to bad packet assumptions. (#1829)

Browse source 
### Summary
- Fixes various exploits that can crash the shard when the client misbehaves.
- Clients will now be disconnected if they send packets that are marked as out of game only (new flag), while they are in-game.


> [!Note]
> **Developer Note**
> Added an `OutOfGameOnly` which should be used to flag packets as only available out of the game.
> This is the opposite of, yet not the converse to `InGameOnly`.
This commit is contained in:
Kamron Batman 2024-06-07 18:08:07 -07:00 • committed by GitHub
parent 2429b00638
commit 6f444488a5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 113 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Projects/Server/Network/NetState/NetState.cs
View file

@ -806,20 +806,27 @@ public partial class NetState : IComparable<NetState>, IValueLinkListNode<NetSta
return ParserState.AwaitingPartialPacket;
}
if (handler.Ingame)
if (handler.InGameOnly)
{
if (Mobile == null)
{
LogInfo($"received packet 0x{packetId:X2} before having been attached to a mobile");
LogInfo($"Received packet 0x{packetId:X2} before having been attached to a mobile.");
return ParserState.Error;
}
if (Mobile.Deleted)
{
LogInfo($"Received packet 0x{packetId:X2} after having been attached to a deleted mobile.");
return ParserState.Error;
}
}
if (handler.OutOfGameOnly && Mobile?.Deleted == false)
{
LogInfo($"Received packet 0x{packetId:X2} after having been attached to a mobile.");
return ParserState.Error;
}
var throttler = handler.ThrottleCallback;
if (throttler != null)
{