fix: Fixes crashing due to bad packet assumptions. (#1829)
### Summary - Fixes various exploits that can crash the shard when the client misbehaves. - Clients will now be disconnected if they send packets that are marked as out of game only (new flag), while they are in-game. > [!Note] > **Developer Note** > Added an `OutOfGameOnly` which should be used to flag packets as only available out of the game. > This is the opposite of, yet not the converse to `InGameOnly`.
This commit is contained in:
parent
2429b00638
commit
6f444488a5
10 changed files with 113 additions and 46 deletions
|
|
@ -21,11 +21,20 @@ public unsafe class PacketHandler
|
|||
{
|
||||
private readonly int _length;
|
||||
|
||||
public PacketHandler(int packetID, int length, bool ingame, delegate*<NetState, SpanReader, void> onReceive)
|
||||
public PacketHandler(
|
||||
int packetID, delegate*<NetState, SpanReader, void> onReceive,
|
||||
int length = 0, bool inGameOnly = false, bool outGameOnly = false
|
||||
) : this(packetID, length, inGameOnly, outGameOnly, onReceive)
|
||||
{
|
||||
|
||||
}
|
||||
|
||||
public PacketHandler(int packetID, int length, bool inGameOnly, bool outGameOnly, delegate*<NetState, SpanReader, void> onReceive)
|
||||
{
|
||||
_length = length;
|
||||
PacketID = packetID;
|
||||
Ingame = ingame;
|
||||
InGameOnly = inGameOnly;
|
||||
OutOfGameOnly = outGameOnly;
|
||||
OnReceive = onReceive;
|
||||
}
|
||||
|
||||
|
|
@ -37,5 +46,7 @@ public unsafe class PacketHandler
|
|||
|
||||
public delegate*<int, NetState, bool> ThrottleCallback { get; set; }
|
||||
|
||||
public bool Ingame { get; }
|
||||
public bool InGameOnly { get; }
|
||||
|
||||
public bool OutOfGameOnly { get; }
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue