warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Fixes crashing due to bad packet assumptions. (#1829)

Browse source 
### Summary
- Fixes various exploits that can crash the shard when the client misbehaves.
- Clients will now be disconnected if they send packets that are marked as out of game only (new flag), while they are in-game.


> [!Note]
> **Developer Note**
> Added an `OutOfGameOnly` which should be used to flag packets as only available out of the game.
> This is the opposite of, yet not the converse to `InGameOnly`.
This commit is contained in:
Kamron Batman 2024-06-07 18:08:07 -07:00 • committed by GitHub
parent 2429b00638
commit 6f444488a5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 113 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Projects/Server/Network/Packets/IncomingPackets.cs
View file

@ -25,9 +25,20 @@ public static class IncomingPackets
public static PacketHandler[] Handlers { get; } = new PacketHandler[0x100];
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static unsafe void Register(int packetID, int length, bool ingame,
delegate*<NetState, SpanReader, void> onReceive) =>
Register(new PacketHandler(packetID, length, ingame, onReceive));
public static unsafe void Register(
int packetID, delegate*<NetState, SpanReader, void> onReceive, int length = 0, bool ingameOnly = false,
bool outgameOnly = false
) => Register(packetID, length, ingameOnly, outgameOnly, onReceive);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static unsafe void Register(
int packetID, int length, bool ingame, delegate*<NetState, SpanReader, void> onReceive
) => Register(packetID, length, ingame, false, onReceive);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static unsafe void Register(
int packetID, int length, bool ingame, bool outgame, delegate*<NetState, SpanReader, void> onReceive
) => Register(new PacketHandler(packetID, length, ingame, outgame, onReceive));
public static void Register(PacketHandler packetHandler)
{