fix(core): Fixes accounts and moves it to codegen (#644)

- [X] Fixes TimeSpan not working with codegen
- [X] Fixes bad check for generic classes with a serialize method and deserialize ctor
- [X] Moves Accounts to codegen so it is versioned
- [X] Fixes deserialization of old Accounts with no version variable.
- [X] Fixes deserialize seek not doing anything. 🙈 
- [X] Adds Email to serialization

Projects/SerializationGenerator/SerializableEntityGeneration/SerializableEntityGeneration.SerializeMethod.cs

@@ -44,12 +44,11 @@ namespace SerializationGenerator
 
             if (isOverride)
             {
-                source.AppendLine();
                 source.AppendLine($"{indent}base.Serialize(writer);");
+                source.AppendLine();
             }
 
             // Version
-            source.AppendLine();
             source.AppendLine($"{indent}writer.{(encodedVersion ? "WriteEncodedInt" : "Write")}(_version);");
 
             foreach (var property in properties)

Projects/SerializationGenerator/SerializableMigration/Rules/PrimitiveTypeMigrationRule.cs

@@ -34,7 +34,7 @@ namespace SerializableMigration
             out string[] ruleArguments
         )
         {
-            if (symbol.IsIpAddress(compilation))
+            if (symbol.IsIpAddress(compilation) || symbol.IsTimeSpan(compilation))
             {
                 ruleArguments = Array.Empty<string>();
                 return true;
@@ -91,6 +91,7 @@ namespace SerializableMigration
             var argument = property.RuleArguments.Length >= 1 ? property.RuleArguments[0] : null;
 
             const string ipAddress = SymbolMetadata.IPADDRESS_CLASS;
+            const string timeSpan = SymbolMetadata.TIMESPAN_STRUCT;
             const string date = "System.DateTime";
 
             var readMethod = property.Type switch
@@ -111,7 +112,8 @@ namespace SerializableMigration
                 "decimal"                           => "ReadDecimal",
                 date when argument == "DeltaTime"   => "ReadDeltaTime",
                 date                                => "ReadDateTime",
-                ipAddress                           => "ReadIPAddress"
+                ipAddress                           => "ReadIPAddress",
+                timeSpan                            => "ReadTimeSpan"
             };
 
             var readArgument = readMethod == "ReadString" && argument == "InternString" ? "true" : "";

Projects/SerializationGenerator/SerializableMigration/Rules/SerializationMethodSignatureMigrationRule.cs

@@ -15,6 +15,7 @@
 
 using System;
 using System.Collections.Immutable;
+using System.Linq;
 using System.Text;
 using Microsoft.CodeAnalysis;
 using SerializationGenerator;
@@ -63,7 +64,7 @@ namespace SerializableMigration
             var argument = property.RuleArguments.Length >= 1 &&
                            property.RuleArguments[0] == "DeserializationRequiresParent" ? ", this" : "";
 
-            source.AppendLine($"{indent}{propertyName} = new {property.Type}(reader{argument})");
+            source.AppendLine($"{indent}{propertyName} = new {property.Type}(reader{argument});");
         }
 
         public void GenerateSerializationMethod(StringBuilder source, string indent, SerializableProperty property)

Projects/SerializationGenerator/SourceGeneration/SymbolMetadata/SymbolMetadata.Builtin.cs

@@ -23,6 +23,13 @@ namespace SerializationGenerator
         public const string HASHSET_CLASS = "System.Collections.Generic.HashSet`1";
         public const string IPADDRESS_CLASS = "System.Net.IPAddress";
         public const string KEYVALUEPAIR_STRUCT = "System.Collections.Generic.KeyValuePair";
+        public const string TIMESPAN_STRUCT = "System.TimeSpan";
+
+        public static bool IsTimeSpan(this ISymbol symbol, Compilation compilation) =>
+            symbol.Equals(
+                compilation.GetTypeByMetadataName(TIMESPAN_STRUCT),
+                SymbolEqualityComparer.Default
+            );
 
         public static bool IsIpAddress(this ISymbol symbol, Compilation compilation) =>
             symbol.Equals(

Projects/SerializationGenerator/SourceGeneration/SymbolMetadata/SymbolMetadata.UO.cs

@@ -73,10 +73,10 @@ namespace SerializationGenerator
                 m => !m.IsStatic &&
                      m.MethodKind == MethodKind.Constructor &&
                      m.Parameters.Length <= 2 &&
-                     m.Parameters[0].Equals(genericReaderInterface, SymbolEqualityComparer.Default)
+                     SymbolEqualityComparer.Default.Equals(m.Parameters[0].Type, genericReaderInterface)
             );
 
-            requiresParent = genericCtor?.Parameters.Length == 2 && genericCtor.Parameters[1].Equals(symbol, SymbolEqualityComparer.Default);
+            requiresParent = genericCtor?.Parameters.Length == 2 && SymbolEqualityComparer.Default.Equals(genericCtor.Parameters[1].Type, symbol);
             return genericCtor != null;
         }
 
@@ -98,7 +98,7 @@ namespace SerializationGenerator
                     m => !m.IsStatic &&
                          m.ReturnsVoid &&
                          m.Parameters.Length == 1 &&
-                         m.Parameters[0].Equals(genericWriterInterface, SymbolEqualityComparer.Default) &&
+                         SymbolEqualityComparer.Default.Equals(m.Parameters[0].Type, genericWriterInterface) &&
                          m.DeclaredAccessibility == Accessibility.Public
                 );
         }